[BUG]: Validate persisted account state against the latest block's state root
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Anfängerfreundlichkeit
- 72/100
Rechercherichtung
Read minichain/persistence.py and trace how load() restores account data for SQLite and legacy JSON, then inspect State.state_root() in minichain/state.py and the latest block in minichain/chain.py. Start with the persistence tests in tests/test_persistence.py and check existing genesis-only coverage. Done means mismatched restored account state raises a clear ValueError while valid SQLite and JSON snapshots still load.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Bug Description
Problem Description
The persistence loading process validates the integrity of the stored blockchain, including block hashes and block linkage. However, after restoring account data from SQLite or a legacy JSON snapshot, it does not verify whether the restored account state matches the state_root committed in the latest block.
As a result, modified or inconsistent persisted account data could potentially be restored even when the stored blockchain passes the existing integrity checks.
Current Behavior
In minichain/persistence.py, the load() function:
- Loads persisted blocks and account data.
- Validates the blockchain's integrity using
_verify_chain_integrity(). - Normalizes the restored account data.
- Assigns the restored data directly to
blockchain.state.accounts.
However, it does not compare the calculated state root of the restored accounts against the latest block's committed state_root.
Expected Behavior
After restoring the account data, the loader should:
- Calculate the state root using the existing
State.state_root()implementation. - Retrieve the expected state root from the latest block.
- Compare both roots.
- Reject the persisted snapshot with a clear
ValueErrorif they do not match.
Valid persisted snapshots should continue to load normally.
Proposed Solution
Extend the existing integrity verification in minichain/persistence.py to validate the restored account state against the latest block's state root.
The implementation should reuse the existing state-root calculation rather than introduce a separate hashing mechanism.
Both SQLite persistence and legacy JSON restoration should retain their existing supported behavior.
Suggested Test Cases
- Valid persisted account state loads successfully.
- Modified account balance causes restoration to fail.
- Modified account nonce causes restoration to fail.
- Modified contract storage causes restoration to fail.
- Missing or modified account data is rejected when it changes the calculated state root.
- Valid genesis-only chain restoration continues to work.
- Valid legacy JSON snapshots continue to load successfully.
Expected Outcome
- Improved persistence integrity.
- Detection of inconsistent or corrupted account data during restoration.
- Consistency between the restored account state and the latest block's commitment.
- Better reliability when restarting blockchain nodes.
Additional Context
Relevant implementation files:
minichain/persistence.pyminichain/state.pyminichain/chain.pytests/test_persistence.py
I would like to work on this issue after maintainer confirmation and follow the existing architecture and testing conventions.
Steps to Reproduce
- Create a MiniChain blockchain instance.
- Create an account and execute a transaction that changes the account's balance or nonce.
- Save the blockchain using the existing persistence mechanism (SQLite or JSON snapshot).
- Directly modify the persisted account data (for example, change the account balance) without modifying the stored blocks.
- Attempt to reload the blockchain using
persistence.load(). - Observe whether the modified account state is successfully restored despite not matching the latest block's committed state root.
Logs and Screenshots
No response
Environment Details
No response
Impact
Medium - Feature works but has issues
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- Vorherrschende Sprache
- Python
- Sterne
- 12
- Forks
- 27
- Ø Merge
- 2 Min.
- Gemergte PRs (30 T.)
- 1
Entwicklungsumgebung
- Enthält ein Dockerfile oder eine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus StabilityNexus/MiniChain
-
[BUG]: Handle JSON-RPC notifications and empty batches correctlyEvtl. vergeben @Muneerali199 hat das vor 10 Tagen übernommen. Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
StabilityNexus/MiniChain#177 · 2 Kommentare ·
Maintainer antworten meist innerhalb von 1 Tag
-
automatic-copyright-year: keep README copyright currentEvtl. vergeben @anshulchikhale30-p hat das vor 7 Tagen übernommen. Offendocumentation enhancement
Schwierigkeit 3/5 Ein halber Tag Anfängerfreundlichkeit 35/100
StabilityNexus/MiniChain#189 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Difficulty: bound per-block EMA moves, add a difficulty floor, and preserve state across restartsEvtl. vergeben @anshulchikhale30-p hat das vor 7 Tagen übernommen. Offenbug documentation enhancement
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 25/100
StabilityNexus/MiniChain#187 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[BUG]: Blocks on a different parent are classified INVALID and get the sender bannedEvtl. vergeben @kansalakshat hat das vor 7 Tagen übernommen. Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 35/100
StabilityNexus/MiniChain#185 ·
Maintainer antworten meist innerhalb von 1 Tag
-
[BUG]: P2P sync downloads full 500-block chunks without headers-first validationEvtl. vergeben @anshulchikhale30-p hat das vor 14 Tagen übernommen. Offenbug documentation enhancement
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 25/100
StabilityNexus/MiniChain#178 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in StabilityNexus/MiniChain
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
huggingface/datasets#9128 ·
Maintainer antworten meist innerhalb von 1 Tag
-
priority:low ready-for-dev
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
OpenHands/extensions#975 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Function/dict state handlers can't supply provider-state injected values (`generate.provider_state`)Offen
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
pact-foundation/pact-python#1789 ·
Maintainer antworten meist innerhalb von 9 Tagen
-
documentation
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
juandresrodca/AdminForge#66 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 68/100
Maintainer antworten meist innerhalb von 1 Tag