[BUG]: Validate persisted account state against the latest block's state root
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 72/100
Línea de trabajo
Read minichain/persistence.py and trace how load() restores account data for SQLite and legacy JSON, then inspect State.state_root() in minichain/state.py and the latest block in minichain/chain.py. Start with the persistence tests in tests/test_persistence.py and check existing genesis-only coverage. Done means mismatched restored account state raises a clear ValueError while valid SQLite and JSON snapshots still load.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Bug Description
Problem Description
The persistence loading process validates the integrity of the stored blockchain, including block hashes and block linkage. However, after restoring account data from SQLite or a legacy JSON snapshot, it does not verify whether the restored account state matches the state_root committed in the latest block.
As a result, modified or inconsistent persisted account data could potentially be restored even when the stored blockchain passes the existing integrity checks.
Current Behavior
In minichain/persistence.py, the load() function:
- Loads persisted blocks and account data.
- Validates the blockchain's integrity using
_verify_chain_integrity(). - Normalizes the restored account data.
- Assigns the restored data directly to
blockchain.state.accounts.
However, it does not compare the calculated state root of the restored accounts against the latest block's committed state_root.
Expected Behavior
After restoring the account data, the loader should:
- Calculate the state root using the existing
State.state_root()implementation. - Retrieve the expected state root from the latest block.
- Compare both roots.
- Reject the persisted snapshot with a clear
ValueErrorif they do not match.
Valid persisted snapshots should continue to load normally.
Proposed Solution
Extend the existing integrity verification in minichain/persistence.py to validate the restored account state against the latest block's state root.
The implementation should reuse the existing state-root calculation rather than introduce a separate hashing mechanism.
Both SQLite persistence and legacy JSON restoration should retain their existing supported behavior.
Suggested Test Cases
- Valid persisted account state loads successfully.
- Modified account balance causes restoration to fail.
- Modified account nonce causes restoration to fail.
- Modified contract storage causes restoration to fail.
- Missing or modified account data is rejected when it changes the calculated state root.
- Valid genesis-only chain restoration continues to work.
- Valid legacy JSON snapshots continue to load successfully.
Expected Outcome
- Improved persistence integrity.
- Detection of inconsistent or corrupted account data during restoration.
- Consistency between the restored account state and the latest block's commitment.
- Better reliability when restarting blockchain nodes.
Additional Context
Relevant implementation files:
minichain/persistence.pyminichain/state.pyminichain/chain.pytests/test_persistence.py
I would like to work on this issue after maintainer confirmation and follow the existing architecture and testing conventions.
Steps to Reproduce
- Create a MiniChain blockchain instance.
- Create an account and execute a transaction that changes the account's balance or nonce.
- Save the blockchain using the existing persistence mechanism (SQLite or JSON snapshot).
- Directly modify the persisted account data (for example, change the account balance) without modifying the stored blocks.
- Attempt to reload the blockchain using
persistence.load(). - Observe whether the modified account state is successfully restored despite not matching the latest block's committed state root.
Logs and Screenshots
No response
Environment Details
No response
Impact
Medium - Feature works but has issues
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- Lenguaje dominante
- Python
- Estrellas
- 12
- Forks
- 27
- Merge medio
- 2 min
- PR fusionados (30 d)
- 1
Preparar el entorno
- Incluye un Dockerfile o un archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de StabilityNexus/MiniChain
-
[BUG]: Handle JSON-RPC notifications and empty batches correctlyPosiblemente ocupada @Muneerali199 la tomó hace 10 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
StabilityNexus/MiniChain#177 · 2 comentarios ·
Los mantenedores suelen responder en 1 día
-
automatic-copyright-year: keep README copyright currentPosiblemente ocupada @anshulchikhale30-p la tomó hace 7 días. Abiertodocumentation enhancement
Dificultad 3/5 Medio día Aptitud para principiantes 35/100
StabilityNexus/MiniChain#189 ·
Los mantenedores suelen responder en 1 día
-
Difficulty: bound per-block EMA moves, add a difficulty floor, and preserve state across restartsPosiblemente ocupada @anshulchikhale30-p la tomó hace 7 días. Abiertobug documentation enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 25/100
StabilityNexus/MiniChain#187 ·
Los mantenedores suelen responder en 1 día
-
[BUG]: Blocks on a different parent are classified INVALID and get the sender bannedPosiblemente ocupada @kansalakshat la tomó hace 7 días. Abiertobug
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
StabilityNexus/MiniChain#185 ·
Los mantenedores suelen responder en 1 día
-
[BUG]: P2P sync downloads full 500-block chunks without headers-first validationPosiblemente ocupada @anshulchikhale30-p la tomó hace 14 días. Abiertobug documentation enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 25/100
StabilityNexus/MiniChain#178 ·
Los mantenedores suelen responder en 1 día
Todos los issues de StabilityNexus/MiniChain
Issues similares
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
huggingface/datasets#9128 ·
Los mantenedores suelen responder en 1 día
-
priority:low ready-for-dev
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
OpenHands/extensions#975 ·
Los mantenedores suelen responder en 1 día
-
Function/dict state handlers can't supply provider-state injected values (`generate.provider_state`)Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
pact-foundation/pact-python#1789 ·
Los mantenedores suelen responder en 9 días
-
documentation
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
juandresrodca/AdminForge#66 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 68/100
Los mantenedores suelen responder en 1 día