[BUG]: Validate persisted account state against the latest block's state root
維護者通常 1 天內回覆
評估
研究方向
Read minichain/persistence.py and trace how load() restores account data for SQLite and legacy JSON, then inspect State.state_root() in minichain/state.py and the latest block in minichain/chain.py. Start with the persistence tests in tests/test_persistence.py and check existing genesis-only coverage. Done means mismatched restored account state raises a clear ValueError while valid SQLite and JSON snapshots still load.
由索引模型根據 Issue 內容生成。
描述
Bug Description
Problem Description
The persistence loading process validates the integrity of the stored blockchain, including block hashes and block linkage. However, after restoring account data from SQLite or a legacy JSON snapshot, it does not verify whether the restored account state matches the state_root committed in the latest block.
As a result, modified or inconsistent persisted account data could potentially be restored even when the stored blockchain passes the existing integrity checks.
Current Behavior
In minichain/persistence.py, the load() function:
- Loads persisted blocks and account data.
- Validates the blockchain's integrity using
_verify_chain_integrity(). - Normalizes the restored account data.
- Assigns the restored data directly to
blockchain.state.accounts.
However, it does not compare the calculated state root of the restored accounts against the latest block's committed state_root.
Expected Behavior
After restoring the account data, the loader should:
- Calculate the state root using the existing
State.state_root()implementation. - Retrieve the expected state root from the latest block.
- Compare both roots.
- Reject the persisted snapshot with a clear
ValueErrorif they do not match.
Valid persisted snapshots should continue to load normally.
Proposed Solution
Extend the existing integrity verification in minichain/persistence.py to validate the restored account state against the latest block's state root.
The implementation should reuse the existing state-root calculation rather than introduce a separate hashing mechanism.
Both SQLite persistence and legacy JSON restoration should retain their existing supported behavior.
Suggested Test Cases
- Valid persisted account state loads successfully.
- Modified account balance causes restoration to fail.
- Modified account nonce causes restoration to fail.
- Modified contract storage causes restoration to fail.
- Missing or modified account data is rejected when it changes the calculated state root.
- Valid genesis-only chain restoration continues to work.
- Valid legacy JSON snapshots continue to load successfully.
Expected Outcome
- Improved persistence integrity.
- Detection of inconsistent or corrupted account data during restoration.
- Consistency between the restored account state and the latest block's commitment.
- Better reliability when restarting blockchain nodes.
Additional Context
Relevant implementation files:
minichain/persistence.pyminichain/state.pyminichain/chain.pytests/test_persistence.py
I would like to work on this issue after maintainer confirmation and follow the existing architecture and testing conventions.
Steps to Reproduce
- Create a MiniChain blockchain instance.
- Create an account and execute a transaction that changes the account's balance or nonce.
- Save the blockchain using the existing persistence mechanism (SQLite or JSON snapshot).
- Directly modify the persisted account data (for example, change the account balance) without modifying the stored blocks.
- Attempt to reload the blockchain using
persistence.load(). - Observe whether the modified account state is successfully restored despite not matching the latest block's committed state root.
Logs and Screenshots
No response
Environment Details
No response
Impact
Medium - Feature works but has issues
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- 主要語言
- Python
- 星號
- 12
- 分支
- 27
- 平均合併
- 2 分鐘
- 30 天內合併 PR
- 1
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
StabilityNexus/MiniChain 的其他 Issue
-
[BUG]: Handle JSON-RPC notifications and empty batches correctly可能已有人在做 @Muneerali199 於 10 天前認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 78/100
StabilityNexus/MiniChain#177 · 2 則留言 ·
維護者通常 1 天內回覆
-
automatic-copyright-year: keep README copyright current可能已有人在做 @anshulchikhale30-p 於 7 天前認領。 未關閉documentation enhancement
難度 3/5 半天 新手友好度 35/100
StabilityNexus/MiniChain#189 ·
維護者通常 1 天內回覆
-
Difficulty: bound per-block EMA moves, add a difficulty floor, and preserve state across restarts可能已有人在做 @anshulchikhale30-p 於 7 天前認領。 未關閉bug documentation enhancement
難度 4/5 3-5 天 新手友好度 25/100
StabilityNexus/MiniChain#187 ·
維護者通常 1 天內回覆
-
[BUG]: Blocks on a different parent are classified INVALID and get the sender banned可能已有人在做 @kansalakshat 於 7 天前認領。 未關閉bug
難度 2/5 1-3 小時 新手友好度 35/100
StabilityNexus/MiniChain#185 ·
維護者通常 1 天內回覆
-
[BUG]: P2P sync downloads full 500-block chunks without headers-first validation可能已有人在做 @anshulchikhale30-p 於 14 天前認領。 未關閉bug documentation enhancement
難度 5/5 一週以上 新手友好度 25/100
StabilityNexus/MiniChain#178 ·
維護者通常 1 天內回覆
查看 StabilityNexus/MiniChain 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 78/100
huggingface/datasets#9128 ·
維護者通常 1 天內回覆
-
priority:low ready-for-dev
難度 2/5 1-3 小時 新手友好度 68/100
OpenHands/extensions#975 ·
維護者通常 1 天內回覆
-
Function/dict state handlers can't supply provider-state injected values (`generate.provider_state`)未關閉
難度 2/5 1-3 小時 新手友好度 78/100
pact-foundation/pact-python#1789 ·
維護者通常 9 天內回覆
-
documentation
難度 2/5 1-3 小時 新手友好度 82/100
juandresrodca/AdminForge#66 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆