[BUG]: Validate persisted account state against the latest block's state root

Aberta
#175 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@JANAKIRAM218 já está trabalhando nisso.

Desde 11/11/2026.

  • #182 de @JANAKIRAM218 — aberto

Avaliação

Dificuldade
3/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
72/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
python
Domínio
backend, databases

Direção de pesquisa

Read minichain/persistence.py and trace how load() restores account data for SQLite and legacy JSON, then inspect State.state_root() in minichain/state.py and the latest block in minichain/chain.py. Start with the persistence tests in tests/test_persistence.py and check existing genesis-only coverage. Done means mismatched restored account state raises a clear ValueError while valid SQLite and JSON snapshots still load.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug
Bug Description

Problem Description

The persistence loading process validates the integrity of the stored blockchain, including block hashes and block linkage. However, after restoring account data from SQLite or a legacy JSON snapshot, it does not verify whether the restored account state matches the state_root committed in the latest block.

As a result, modified or inconsistent persisted account data could potentially be restored even when the stored blockchain passes the existing integrity checks.

Current Behavior

In minichain/persistence.py, the load() function:

  1. Loads persisted blocks and account data.
  2. Validates the blockchain's integrity using _verify_chain_integrity().
  3. Normalizes the restored account data.
  4. Assigns the restored data directly to blockchain.state.accounts.

However, it does not compare the calculated state root of the restored accounts against the latest block's committed state_root.

Expected Behavior

After restoring the account data, the loader should:

  1. Calculate the state root using the existing State.state_root() implementation.
  2. Retrieve the expected state root from the latest block.
  3. Compare both roots.
  4. Reject the persisted snapshot with a clear ValueError if they do not match.

Valid persisted snapshots should continue to load normally.

Proposed Solution

Extend the existing integrity verification in minichain/persistence.py to validate the restored account state against the latest block's state root.

The implementation should reuse the existing state-root calculation rather than introduce a separate hashing mechanism.

Both SQLite persistence and legacy JSON restoration should retain their existing supported behavior.

Suggested Test Cases

  • Valid persisted account state loads successfully.
  • Modified account balance causes restoration to fail.
  • Modified account nonce causes restoration to fail.
  • Modified contract storage causes restoration to fail.
  • Missing or modified account data is rejected when it changes the calculated state root.
  • Valid genesis-only chain restoration continues to work.
  • Valid legacy JSON snapshots continue to load successfully.

Expected Outcome

  • Improved persistence integrity.
  • Detection of inconsistent or corrupted account data during restoration.
  • Consistency between the restored account state and the latest block's commitment.
  • Better reliability when restarting blockchain nodes.

Additional Context

Relevant implementation files:

  • minichain/persistence.py
  • minichain/state.py
  • minichain/chain.py
  • tests/test_persistence.py

I would like to work on this issue after maintainer confirmation and follow the existing architecture and testing conventions.

Steps to Reproduce
  1. Create a MiniChain blockchain instance.
  2. Create an account and execute a transaction that changes the account's balance or nonce.
  3. Save the blockchain using the existing persistence mechanism (SQLite or JSON snapshot).
  4. Directly modify the persisted account data (for example, change the account balance) without modifying the stored blocks.
  5. Attempt to reload the blockchain using persistence.load().
  6. Observe whether the modified account state is successfully restored despite not matching the latest block's committed state root.
Logs and Screenshots

No response

Environment Details

No response

Impact

Medium - Feature works but has issues

Code of Conduct
  • I have joined the Discord server and will post updates there
  • I have searched existing issues to avoid duplicates
Linguagem predominante
Python
Estrelas
12
Forks
27
Merge médio
2min
PRs com merge (30d)
1

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de StabilityNexus/MiniChain

Todas as issues de StabilityNexus/MiniChain

Issues semelhantes

Mais issues de Python

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.