[BUG]: Validate persisted account state against the latest block's state root
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Facilidade para iniciantes
- 72/100
Direção de pesquisa
Read minichain/persistence.py and trace how load() restores account data for SQLite and legacy JSON, then inspect State.state_root() in minichain/state.py and the latest block in minichain/chain.py. Start with the persistence tests in tests/test_persistence.py and check existing genesis-only coverage. Done means mismatched restored account state raises a clear ValueError while valid SQLite and JSON snapshots still load.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Bug Description
Problem Description
The persistence loading process validates the integrity of the stored blockchain, including block hashes and block linkage. However, after restoring account data from SQLite or a legacy JSON snapshot, it does not verify whether the restored account state matches the state_root committed in the latest block.
As a result, modified or inconsistent persisted account data could potentially be restored even when the stored blockchain passes the existing integrity checks.
Current Behavior
In minichain/persistence.py, the load() function:
- Loads persisted blocks and account data.
- Validates the blockchain's integrity using
_verify_chain_integrity(). - Normalizes the restored account data.
- Assigns the restored data directly to
blockchain.state.accounts.
However, it does not compare the calculated state root of the restored accounts against the latest block's committed state_root.
Expected Behavior
After restoring the account data, the loader should:
- Calculate the state root using the existing
State.state_root()implementation. - Retrieve the expected state root from the latest block.
- Compare both roots.
- Reject the persisted snapshot with a clear
ValueErrorif they do not match.
Valid persisted snapshots should continue to load normally.
Proposed Solution
Extend the existing integrity verification in minichain/persistence.py to validate the restored account state against the latest block's state root.
The implementation should reuse the existing state-root calculation rather than introduce a separate hashing mechanism.
Both SQLite persistence and legacy JSON restoration should retain their existing supported behavior.
Suggested Test Cases
- Valid persisted account state loads successfully.
- Modified account balance causes restoration to fail.
- Modified account nonce causes restoration to fail.
- Modified contract storage causes restoration to fail.
- Missing or modified account data is rejected when it changes the calculated state root.
- Valid genesis-only chain restoration continues to work.
- Valid legacy JSON snapshots continue to load successfully.
Expected Outcome
- Improved persistence integrity.
- Detection of inconsistent or corrupted account data during restoration.
- Consistency between the restored account state and the latest block's commitment.
- Better reliability when restarting blockchain nodes.
Additional Context
Relevant implementation files:
minichain/persistence.pyminichain/state.pyminichain/chain.pytests/test_persistence.py
I would like to work on this issue after maintainer confirmation and follow the existing architecture and testing conventions.
Steps to Reproduce
- Create a MiniChain blockchain instance.
- Create an account and execute a transaction that changes the account's balance or nonce.
- Save the blockchain using the existing persistence mechanism (SQLite or JSON snapshot).
- Directly modify the persisted account data (for example, change the account balance) without modifying the stored blocks.
- Attempt to reload the blockchain using
persistence.load(). - Observe whether the modified account state is successfully restored despite not matching the latest block's committed state root.
Logs and Screenshots
No response
Environment Details
No response
Impact
Medium - Feature works but has issues
Code of Conduct
- I have joined the Discord server and will post updates there
- I have searched existing issues to avoid duplicates
- Linguagem predominante
- Python
- Estrelas
- 12
- Forks
- 27
- Merge médio
- 2min
- PRs com merge (30d)
- 1
Preparar o ambiente
- Inclui um Dockerfile ou arquivo Docker Compose
- Sem modelo de pull request
- Ler o guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de StabilityNexus/MiniChain
-
[BUG]: Handle JSON-RPC notifications and empty batches correctlyTalvez já em andamento @Muneerali199 assumiu há 10 dias. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
StabilityNexus/MiniChain#177 · 2 comentários ·
Mantenedores costumam responder em até 1 dia
-
automatic-copyright-year: keep README copyright currentTalvez já em andamento @anshulchikhale30-p assumiu há 7 dias. Abertadocumentation enhancement
Dificuldade 3/5 Meio dia Facilidade para iniciantes 35/100
StabilityNexus/MiniChain#189 ·
Mantenedores costumam responder em até 1 dia
-
Difficulty: bound per-block EMA moves, add a difficulty floor, and preserve state across restartsTalvez já em andamento @anshulchikhale30-p assumiu há 7 dias. Abertabug documentation enhancement
Dificuldade 4/5 3-5 dias Facilidade para iniciantes 25/100
StabilityNexus/MiniChain#187 ·
Mantenedores costumam responder em até 1 dia
-
[BUG]: Blocks on a different parent are classified INVALID and get the sender bannedTalvez já em andamento @kansalakshat assumiu há 7 dias. Abertabug
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 35/100
StabilityNexus/MiniChain#185 ·
Mantenedores costumam responder em até 1 dia
-
[BUG]: P2P sync downloads full 500-block chunks without headers-first validationTalvez já em andamento @anshulchikhale30-p assumiu há 14 dias. Abertabug documentation enhancement
Dificuldade 5/5 Mais de uma semana Facilidade para iniciantes 25/100
StabilityNexus/MiniChain#178 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de StabilityNexus/MiniChain
Issues semelhantes
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
huggingface/datasets#9128 ·
Mantenedores costumam responder em até 1 dia
-
priority:low ready-for-dev
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
OpenHands/extensions#975 ·
Mantenedores costumam responder em até 1 dia
-
Function/dict state handlers can't supply provider-state injected values (`generate.provider_state`)Aberta
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 78/100
pact-foundation/pact-python#1789 ·
Mantenedores costumam responder em até 9 dias
-
documentation
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 82/100
juandresrodca/AdminForge#66 ·
Mantenedores costumam responder em até 1 dia
-
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 68/100
Mantenedores costumam responder em até 1 dia