Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

OSPS-SA-03.02 sets security.threat_model.path unconditionally

Open
  • Is something wrong?
#545 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
security

Research direction

Start by reading the generate_threat_model plugin handler and the file_create.project_reference behavior described in FR-015/FR-016. Check how the handler reports file creation and how the existing reference value is handled. Done means the reference is recorded only for a file created in that run, without replacing a different existing path.

Written by the indexing model from the issue text.

Description

module-baseline quality

The OSPS-SA-03.02 remediation sets security.threat_model.path through an unconditional project_update, whether or not a threat model file was created in that run. It can also replace a path the project already set.

On the 043 branch, other controls record file references only through file_create.project_reference: the reference is recorded only for a file created in that run, and only into an empty field (FR-015/FR-016). SA-03.02 generates its file through the generate_threat_model plugin handler rather than file_create, so it was left as it was.

Fix: record the reference only when the handler reports that it created the file, using the same "empty or equal" rule. Related to #482.

Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).

Dominant language
Python
Stars
22
Forks
27
Avg merge
2d 28m
Merged PRs (30d)
40

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from darnitdevorg/darnit

All issues in darnitdevorg/darnit

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.