Plugins hard-code version "0.1.0" while the packages are at 0.1.1
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 83/100
Research direction
Read the three implementation files named in the issue and compare their version properties with the CLI’s existing importlib.metadata.version(...) usage for darnit-core. Update the implementation tests in tests/darnit_baseline/test_implementation.py and tests/darnit_testchecks/test_implementation.py to compare against package metadata. Done means the plugins report their installed package versions and the tests no longer expect a fixed string.
Written by the indexing model from the issue text.
Description
The version property of each plugin returns a fixed string:
darnit_baseline/implementation.py:return "0.1.0"darnit_gittuf/implementation.py:return "0.1.0"darnit_csl/implementation.py:return "0.1.0"
The packages are at 0.1.1, and will be 0.2.0 at the next release. Tests assert the fixed string (tests/darnit_baseline/test_implementation.py, tests/darnit_testchecks/test_implementation.py).
Small impact. As far as I can see, the value is only used in the discovery log line (Discovered implementation: <name> v0.1.0), which then shows the wrong version.
Possible fix
Read it from the package metadata, as the CLI already does for darnit-core (importlib.metadata.version(...)), and change the tests to compare against that.
Related: #494 (other version strings that disagree).
- Dominant language
- Python
- Stars
- 22
- Forks
- 27
- Avg merge
- 2d 28m
- Merged PRs (30d)
- 40
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from darnitdevorg/darnit
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
darnitdevorg/darnit#589 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
darnitdevorg/darnit#585 ·
Maintainers usually reply within 1 day
-
quality
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
darnitdevorg/darnit#523 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
darnitdevorg/darnit#516 ·
Maintainers usually reply within 1 day
-
good first issue module-core
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
darnitdevorg/darnit#506 ·
Maintainers usually reply within 1 day
All issues in darnitdevorg/darnit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 1/5 Under an hour Newbie friendliness 62/100
-
Difficulty 1/5 Under an hour Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
topoteretes/cognee#5773 ·
Maintainers usually reply within 1 day
-
MiKTeX: a failed build reports no errors because texify --quiet switches the log to file:line: styleOpen
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
SublimeText/LaTeXTools#1718 ·