create_security_policy fails on every call; its template parameter is ignored
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 35/100
Research direction
Start with tests/darnit_baseline/test_tools_signatures.py and inspect the create_security_policy tool and the control template it uses. The issue leaves a choice between implementing the standard, minimal, and enterprise TOML variants or removing the pinned parameter. Done means the parameter is honored or removed consistently, while the existing SECURITY.md behavior remains unchanged.
Written by the indexing model from the issue text.
Description
On main (0581c0d), the create_security_policy MCP tool fails on every call. It passes an EffectiveConfig to FrameworkConfig(**...), which raises. When it did produce output, it also reported "Created" when SECURITY.md already existed.
Fixed on the 043 branch: the tool runs OSPS-VM-02.01 through the remediation executor and the run manifest, never overwrites an existing SECURITY.md (it reports unchanged / already_exists), and returns the structured run.
Still open on the branch: the template parameter (standard / minimal / enterprise) is accepted but ignored; every call renders the control's own template. Either implement the variants as TOML templates selected by the parameter, or remove the parameter (it is pinned by tests/darnit_baseline/test_tools_signatures.py).
Found while implementing feature 043 (remediation safety, branch 043-remediation-safety, not yet merged).
- Dominant language
- Python
- Stars
- 22
- Forks
- 27
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 35
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from darnitdevorg/darnit
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
darnitdevorg/darnit#587 ·
Maintainers usually reply within 1 day
-
needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
darnitdevorg/darnit#585 ·
Maintainers usually reply within 1 day
-
quality
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
darnitdevorg/darnit#523 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
darnitdevorg/darnit#516 ·
Maintainers usually reply within 1 day
-
good first issue module-core
Difficulty 1/5 1-3 hours Newbie friendliness 88/100
darnitdevorg/darnit#506 ·
Maintainers usually reply within 1 day
All issues in darnitdevorg/darnit
Similar issues
-
bug Triage-Needed
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
FuRongJun-1999/dsh-memory#170 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 82/100
521xueweihan/HelloGitHub#3940 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100