Setup's first step loses a failed menu bar change's error while Continue stays disabled

Open
#801 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift
Domain
desktop

Research direction

Read Sources/StableBar/SetupWindow.swift, especially SetupSession.refreshAccess() and preview(), then trace how the placement step stores its error and how SetupPlacement.Phase.failed affects Continue. Check the related behavior covered by aFailedMenuBarChangeKeepsTheFirstStepWaiting. Done when the placement error remains visible while Continue waits and clears after a new choice or successful retry.

Written by the indexing model from the issue text.

Description

bug

What happens

On setup's first step, when hiding or showing the macOS menu bar fails, setup shows "StableBar couldn’t hide the macOS menu bar. …" and Continue stays disabled. As soon as StableBar becomes active again, for example after switching to System Settings and back, the error disappears but Continue stays disabled, and nothing says why.

Steps to reproduce

System Events has to fail the change, so this is hard to trigger by hand:

  1. Start setup without full Calendar access (the usual case).
  2. Choose Replace the menu bar while System Events fails the change, for example by timing out.
  3. Switch to another app, then back to StableBar.

Expected

The error stays as long as Continue waits on it, and clears once a new choice or a retry works.

Environment

main at 5f9e2700, and #787 at 2a163f27. Found in code review, not reported by a user.

Evidence

CodeRabbit's review of #787: https://github.com/Seb-GRAF/StableBar/pull/787#pullrequestreview-5951404412

Diagnosis

  • SetupSession.refreshAccess() (Sources/StableBar/SetupWindow.swift) runs whenever StableBar becomes active, and calls preview() unless Calendar access is full.
  • preview() sets error = nil once the preview loads, which also clears the error the placement step set.
  • On main, the first step keeps waiting after a change that fails without taking effect, because placementTookEffect sees the menu bar doesn't match. #787 also holds Continue after a change that throws but took effect (SetupPlacement.Phase.failed, pinned by aFailedMenuBarChangeKeepsTheFirstStepWaiting), so both cases end up stuck without an error.
  • Choosing the same placement again retries the change and gets out of it.

One way to fix it: keep the placement's error apart from the preview's, so a preview that loads doesn't clear it.

Related

  • #787: adds the second case; CodeRabbit flagged it there.
  • #497 / #498: Skip setup while a change is still running; a failed change goes by what macOS reports.
  • #788 / #789: Skip setup while setup waits for Automation access.

Triaged by Claude Code (Claude Opus 5.5).

Dominant language
Swift
Stars
184
Forks
12
Avg merge
3h 50m
Merged PRs (30d)
387

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Seb-GRAF/StableBar

All issues in Seb-GRAF/StableBar

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.