Setup's first step loses a failed menu bar change's error while Continue stays disabled
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 72/100
Research direction
Read Sources/StableBar/SetupWindow.swift, especially SetupSession.refreshAccess() and preview(), then trace how the placement step stores its error and how SetupPlacement.Phase.failed affects Continue. Check the related behavior covered by aFailedMenuBarChangeKeepsTheFirstStepWaiting. Done when the placement error remains visible while Continue waits and clears after a new choice or successful retry.
Written by the indexing model from the issue text.
Description
What happens
On setup's first step, when hiding or showing the macOS menu bar fails, setup shows "StableBar couldn’t hide the macOS menu bar. …" and Continue stays disabled. As soon as StableBar becomes active again, for example after switching to System Settings and back, the error disappears but Continue stays disabled, and nothing says why.
Steps to reproduce
System Events has to fail the change, so this is hard to trigger by hand:
- Start setup without full Calendar access (the usual case).
- Choose Replace the menu bar while System Events fails the change, for example by timing out.
- Switch to another app, then back to StableBar.
Expected
The error stays as long as Continue waits on it, and clears once a new choice or a retry works.
Environment
main at 5f9e2700, and #787 at 2a163f27. Found in code review, not reported by a user.
Evidence
CodeRabbit's review of #787: https://github.com/Seb-GRAF/StableBar/pull/787#pullrequestreview-5951404412
Diagnosis
SetupSession.refreshAccess()(Sources/StableBar/SetupWindow.swift) runs whenever StableBar becomes active, and callspreview()unless Calendar access is full.preview()setserror = nilonce the preview loads, which also clears the error the placement step set.- On
main, the first step keeps waiting after a change that fails without taking effect, becauseplacementTookEffectsees the menu bar doesn't match. #787 also holds Continue after a change that throws but took effect (SetupPlacement.Phase.failed, pinned byaFailedMenuBarChangeKeepsTheFirstStepWaiting), so both cases end up stuck without an error. - Choosing the same placement again retries the change and gets out of it.
One way to fix it: keep the placement's error apart from the preview's, so a preview that loads doesn't clear it.
Related
- #787: adds the second case; CodeRabbit flagged it there.
- #497 / #498: Skip setup while a change is still running; a failed change goes by what macOS reports.
- #788 / #789: Skip setup while setup waits for Automation access.
Triaged by Claude Code (Claude Opus 5.5).
- Dominant language
- Swift
- Stars
- 184
- Forks
- 12
- Avg merge
- 3h 50m
- Merged PRs (30d)
- 387
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from Seb-GRAF/StableBar
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 52/100
Maintainers usually reply within 1 day
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changePossibly taken @Jonathanm10 claimed this today. Openneeds-triage
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
enhancement
Difficulty 5/5 Over a week Newbie friendliness 30/100
Maintainers usually reply within 1 day
-
Allow the App Menu to display the frontmost app iconPossibly taken @khatami10 claimed this today. Openenhancement needs-triage
Difficulty 3/5 1-2 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in Seb-GRAF/StableBar
Similar issues
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day