Setup's first step loses a failed menu bar change's error while Continue stays disabled
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Aptitud para principiantes
- 72/100
Línea de trabajo
Read Sources/StableBar/SetupWindow.swift, especially SetupSession.refreshAccess() and preview(), then trace how the placement step stores its error and how SetupPlacement.Phase.failed affects Continue. Check the related behavior covered by aFailedMenuBarChangeKeepsTheFirstStepWaiting. Done when the placement error remains visible while Continue waits and clears after a new choice or successful retry.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
What happens
On setup's first step, when hiding or showing the macOS menu bar fails, setup shows "StableBar couldn’t hide the macOS menu bar. …" and Continue stays disabled. As soon as StableBar becomes active again, for example after switching to System Settings and back, the error disappears but Continue stays disabled, and nothing says why.
Steps to reproduce
System Events has to fail the change, so this is hard to trigger by hand:
- Start setup without full Calendar access (the usual case).
- Choose Replace the menu bar while System Events fails the change, for example by timing out.
- Switch to another app, then back to StableBar.
Expected
The error stays as long as Continue waits on it, and clears once a new choice or a retry works.
Environment
main at 5f9e2700, and #787 at 2a163f27. Found in code review, not reported by a user.
Evidence
CodeRabbit's review of #787: https://github.com/Seb-GRAF/StableBar/pull/787#pullrequestreview-5951404412
Diagnosis
SetupSession.refreshAccess()(Sources/StableBar/SetupWindow.swift) runs whenever StableBar becomes active, and callspreview()unless Calendar access is full.preview()setserror = nilonce the preview loads, which also clears the error the placement step set.- On
main, the first step keeps waiting after a change that fails without taking effect, becauseplacementTookEffectsees the menu bar doesn't match. #787 also holds Continue after a change that throws but took effect (SetupPlacement.Phase.failed, pinned byaFailedMenuBarChangeKeepsTheFirstStepWaiting), so both cases end up stuck without an error. - Choosing the same placement again retries the change and gets out of it.
One way to fix it: keep the placement's error apart from the preview's, so a preview that loads doesn't clear it.
Related
- #787: adds the second case; CodeRabbit flagged it there.
- #497 / #498: Skip setup while a change is still running; a failed change goes by what macOS reports.
- #788 / #789: Skip setup while setup waits for Automation access.
Triaged by Claude Code (Claude Opus 5.5).
- Lenguaje dominante
- Swift
- Estrellas
- 184
- Forks
- 12
- Merge medio
- 3 h 50 min
- PR fusionados (30 d)
- 387
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de Seb-GRAF/StableBar
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 4/5 3-5 días Aptitud para principiantes 52/100
Los mantenedores suelen responder en 1 día
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changePosiblemente ocupada @Jonathanm10 la tomó hoy. Abiertoneeds-triage
Dificultad 2/5 1-3 horas Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 5/5 Más de una semana Aptitud para principiantes 30/100
Los mantenedores suelen responder en 1 día
-
Allow the App Menu to display the frontmost app iconPosiblemente ocupada @khatami10 la tomó hoy. Abiertoenhancement needs-triage
Dificultad 3/5 1-2 días Aptitud para principiantes 35/100
Los mantenedores suelen responder en 1 día
Todos los issues de Seb-GRAF/StableBar
Issues similares
-
good first issue help wanted testing
Dificultad 1/5 Menos de una hora Aptitud para principiantes 78/100
-
area:cli documentation good first issue priority:low
Dificultad 1/5 Menos de una hora Aptitud para principiantes 94/100
isaaclins/freesnitch#430 ·
Los mantenedores suelen responder en 1 día
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Dificultad 2/5 1-3 horas Aptitud para principiantes 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
Los mantenedores suelen responder en 1 día