Setup's first step loses a failed menu bar change's error while Continue stays disabled
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 72/100
Direzione di ricerca
Read Sources/StableBar/SetupWindow.swift, especially SetupSession.refreshAccess() and preview(), then trace how the placement step stores its error and how SetupPlacement.Phase.failed affects Continue. Check the related behavior covered by aFailedMenuBarChangeKeepsTheFirstStepWaiting. Done when the placement error remains visible while Continue waits and clears after a new choice or successful retry.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
On setup's first step, when hiding or showing the macOS menu bar fails, setup shows "StableBar couldn’t hide the macOS menu bar. …" and Continue stays disabled. As soon as StableBar becomes active again, for example after switching to System Settings and back, the error disappears but Continue stays disabled, and nothing says why.
Steps to reproduce
System Events has to fail the change, so this is hard to trigger by hand:
- Start setup without full Calendar access (the usual case).
- Choose Replace the menu bar while System Events fails the change, for example by timing out.
- Switch to another app, then back to StableBar.
Expected
The error stays as long as Continue waits on it, and clears once a new choice or a retry works.
Environment
main at 5f9e2700, and #787 at 2a163f27. Found in code review, not reported by a user.
Evidence
CodeRabbit's review of #787: https://github.com/Seb-GRAF/StableBar/pull/787#pullrequestreview-5951404412
Diagnosis
SetupSession.refreshAccess()(Sources/StableBar/SetupWindow.swift) runs whenever StableBar becomes active, and callspreview()unless Calendar access is full.preview()setserror = nilonce the preview loads, which also clears the error the placement step set.- On
main, the first step keeps waiting after a change that fails without taking effect, becauseplacementTookEffectsees the menu bar doesn't match. #787 also holds Continue after a change that throws but took effect (SetupPlacement.Phase.failed, pinned byaFailedMenuBarChangeKeepsTheFirstStepWaiting), so both cases end up stuck without an error. - Choosing the same placement again retries the change and gets out of it.
One way to fix it: keep the placement's error apart from the preview's, so a preview that loads doesn't clear it.
Related
- #787: adds the second case; CodeRabbit flagged it there.
- #497 / #498: Skip setup while a change is still running; a failed change goes by what macOS reports.
- #788 / #789: Skip setup while setup waits for Automation access.
Triaged by Claude Code (Claude Opus 5.5).
- Lingua principale
- Swift
- Stelle
- 184
- Fork
- 12
- Merge medio
- 3h 50m
- PR unite (30g)
- 387
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Seb-GRAF/StableBar
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
I maintainer di solito rispondono entro 1 giorno
-
Menu bar items drawn as in the menu bar show the wrong part of the menu bar after a display changeForse già presa @Jonathanm10 l’ha presa oggi. Apertaneeds-triage
Difficoltà 2/5 1-3 ore Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 5/5 Più di una settimana Idoneità per principianti 30/100
I maintainer di solito rispondono entro 1 giorno
-
Allow the App Menu to display the frontmost app iconForse già presa @khatami10 l’ha presa oggi. Apertaenhancement needs-triage
Difficoltà 3/5 1-2 giorni Idoneità per principianti 35/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di Seb-GRAF/StableBar
Issue simili
-
good first issue help wanted testing
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
-
area:cli documentation good first issue priority:low
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 94/100
isaaclins/freesnitch#430 ·
I maintainer di solito rispondono entro 1 giorno
-
bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
MasterJ93/ATProtoKit#354 ·
-
enhancement help wanted
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
I maintainer di solito rispondono entro 1 giorno