[Bug]: `LinkRecord` and `ProfileLinkViewDefinition` are missing `labels`
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 82/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- swift
- Domain
- backend-api-design
Research direction
Start with AppBskyActorLink.swift and AppBskyActorDefs.swift, then compare the two model definitions with the linked Bluesky lexicons. Add the specified labels fields using the stated lexicon types; done when both models expose the matching fields and any relevant model tests pass.
Written by the indexing model from the issue text.
Description
Summary
LinkRecordandProfileLinkViewDefinitiondo not match their lexicon definitions:labels` is missing from both.
Reproduction Steps
- Compare
AppBskyLexicon.Actor.LinkRecordwithapp.bsky.actor.link. - Compare
AppBskyLexicon.Actor.ProfileLinkViewDefinitionwithapp.bsky.actor.defs#profileLinkView.
Expected Results
Both models have labels as defined in the lexicons.
Actual Results
Neither model has labels.
What operating systems did you experience this bug?
macOS
Operating System Version
macOS Golden Gate 27.2.1
ATProtoKit Version
0.34.1
Additional Context
| Lexicon | Field | Missing from |
|---|---|---|
app.bsky.actor.link |
labels (union of com.atproto.label.defs#selfLabels) |
LinkRecord (AppBskyActorLink.swift) |
app.bsky.actor.defs#profileLinkView |
labels (array of com.atproto.label.defs#label) |
ProfileLinkViewDefinition (AppBskyActorDefs.swift) |
- Dominant language
- Swift
- Stars
- 226
- Forks
- 40
- Avg merge
- 2h 56m
- Merged PRs (30d)
- 3
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MasterJ93/ATProtoKit
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
MasterJ93/ATProtoKit#352 ·
-
[Feature Enhancement]: Add `sort` parameter to `getQuotes`Possibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
MasterJ93/ATProtoKit#346 · 1 comment ·
-
[Feature Request]: Add `app.bsky.actor.contentVisibilityDeclaration` record supportPossibly taken A pull request linked to this issue is open or already merged. Opennew feature
Difficulty 3/5 1-2 days Newbie friendliness 68/100
MasterJ93/ATProtoKit#350 · 4 comments ·
-
[Feature Enhancement]: Support scoped mutes (`onlyReposts` / `onlyQuoteposts`) in `muteActor`Possibly taken A pull request linked to this issue is open or already merged. Openenhancement
Difficulty 3/5 1-2 days Newbie friendliness 72/100
MasterJ93/ATProtoKit#348 · 1 comment ·
-
enhancement
Difficulty 4/5 1-2 days Newbie friendliness 52/100
MasterJ93/ATProtoKit#337 · 3 comments ·
All issues in MasterJ93/ATProtoKit
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
good first issue help wanted testing
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
area:cli documentation good first issue priority:low
Difficulty 1/5 Under an hour Newbie friendliness 94/100
isaaclins/freesnitch#430 ·
Maintainers usually reply within 1 day
-
enhancement help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
heysidhant/appvanish#4 ·
-
bug priority:low status:queued
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day