[Bug]: `LinkRecord` and `ProfileLinkViewDefinition` are missing `labels`

Open Beginner friendly
#354 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
swift

Research direction

Start with AppBskyActorLink.swift and AppBskyActorDefs.swift, then compare the two model definitions with the linked Bluesky lexicons. Add the specified labels fields using the stated lexicon types; done when both models expose the matching fields and any relevant model tests pass.

Written by the indexing model from the issue text.

Description

bug
Summary

LinkRecordandProfileLinkViewDefinitiondo not match their lexicon definitions:labels` is missing from both.

Reproduction Steps
  1. Compare AppBskyLexicon.Actor.LinkRecord with app.bsky.actor.link.
  2. Compare AppBskyLexicon.Actor.ProfileLinkViewDefinition with app.bsky.actor.defs#profileLinkView.
Expected Results

Both models have labels as defined in the lexicons.

Actual Results

Neither model has labels.

What operating systems did you experience this bug?

macOS

Operating System Version

macOS Golden Gate 27.2.1

ATProtoKit Version

0.34.1

Additional Context
Lexicon Field Missing from
app.bsky.actor.link labels (union of com.atproto.label.defs#selfLabels) LinkRecord (AppBskyActorLink.swift)
app.bsky.actor.defs#profileLinkView labels (array of com.atproto.label.defs#label) ProfileLinkViewDefinition (AppBskyActorDefs.swift)
Dominant language
Swift
Stars
226
Forks
40
Avg merge
2h 56m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MasterJ93/ATProtoKit

All issues in MasterJ93/ATProtoKit

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.