Setup's first step loses a failed menu bar change's error while Continue stays disabled

オープン
#801 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

メンテナーはふだん 1 日以内に返信

まだ誰も着手していません。

評価

難易度
3/5
見積もり時間
1〜2日
初心者へのやさしさ
72/100
issue の種類
バグ
明瞭さ
明確に書かれている
活発さ
活発
技術スタック
swift
領域
desktop

調査の方向性

Read Sources/StableBar/SetupWindow.swift, especially SetupSession.refreshAccess() and preview(), then trace how the placement step stores its error and how SetupPlacement.Phase.failed affects Continue. Check the related behavior covered by aFailedMenuBarChangeKeepsTheFirstStepWaiting. Done when the placement error remains visible while Continue waits and clears after a new choice or successful retry.

索引モデルが issue の本文から書いたものです。

説明

bug

What happens

On setup's first step, when hiding or showing the macOS menu bar fails, setup shows "StableBar couldn’t hide the macOS menu bar. …" and Continue stays disabled. As soon as StableBar becomes active again, for example after switching to System Settings and back, the error disappears but Continue stays disabled, and nothing says why.

Steps to reproduce

System Events has to fail the change, so this is hard to trigger by hand:

  1. Start setup without full Calendar access (the usual case).
  2. Choose Replace the menu bar while System Events fails the change, for example by timing out.
  3. Switch to another app, then back to StableBar.

Expected

The error stays as long as Continue waits on it, and clears once a new choice or a retry works.

Environment

main at 5f9e2700, and #787 at 2a163f27. Found in code review, not reported by a user.

Evidence

CodeRabbit's review of #787: https://github.com/Seb-GRAF/StableBar/pull/787#pullrequestreview-5951404412

Diagnosis

  • SetupSession.refreshAccess() (Sources/StableBar/SetupWindow.swift) runs whenever StableBar becomes active, and calls preview() unless Calendar access is full.
  • preview() sets error = nil once the preview loads, which also clears the error the placement step set.
  • On main, the first step keeps waiting after a change that fails without taking effect, because placementTookEffect sees the menu bar doesn't match. #787 also holds Continue after a change that throws but took effect (SetupPlacement.Phase.failed, pinned by aFailedMenuBarChangeKeepsTheFirstStepWaiting), so both cases end up stuck without an error.
  • Choosing the same placement again retries the change and gets out of it.

One way to fix it: keep the placement's error apart from the preview's, so a preview that loads doesn't clear it.

Related

  • #787: adds the second case; CodeRabbit flagged it there.
  • #497 / #498: Skip setup while a change is still running; a failed change goes by what macOS reports.
  • #788 / #789: Skip setup while setup waits for Automation access.

Triaged by Claude Code (Claude Opus 5.5).

主要言語
Swift
スター
184
フォーク
12
平均マージ
3時間 50分
マージ済み PR(30日)
387

環境構築

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

Seb-GRAF/StableBar のほかの issue

Seb-GRAF/StableBar の issue をすべて見る

似ている issue

Swift の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。