Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Follow-ups from #2160: qualifying-age docstring, UC work-related groups property-file speed, changelog fragment example

Open Beginner friendly
  • Is something wrong?
#2,162 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
88/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
documentation, testing

Research direction

Three independent follow-ups, each with its target named. (1) Find the docstring of has_attained_state_pension_credit_qualifying_age (grep under policyengine_uk/) and apply the suggested wording about the 6 November 1953 birth date; the formula stays untouched. (2) Add pytestmark = pytest.mark.usefixtures("cloned_uk_tax_benefit_system") at the top of policyengine_uk/tests/test_uc_work_related_groups_properties.py, copying the pattern from test_ni_class_4_properties.py, then run the file to confirm all 14 tests pass. (3) In docs/engineering/skills/github-prs.md lines 43-48, drop the leading - from the changelog-fragment example so towncrier's default template does not render - - . Done when the tests pass and the example no longer starts with a bullet.

Written by the indexing model from the issue text.

Description

Three small follow-ups found while reviewing #2160. Each is outside that PR's scope.

  1. Qualifying-age documentation. The documentation of has_attained_state_pension_credit_qualifying_age (from #1907) says men born before 6 December 1953 "reach it before their own State Pension age of 65". For a man born on 6 November 1953, the qualifying age (Pensions Act 1995 Sch 4 para 1 table 1: "6th November 1953 to 5th December 1953", 6 November 2018) falls on his 65th birthday. A check of every birth date from 1880 to 5 December 1953 found that is the only date where the two coincide. Suggested wording: "reach it before their own State Pension age of 65 (on it, for a birth on 6 November 1953)". The formula is unaffected.
  2. Property-file speed. policyengine_uk/tests/test_uc_work_related_groups_properties.py lacks the pytestmark = pytest.mark.usefixtures("cloned_uk_tax_benefit_system") used by the repo's other property files (test_ni_class_4_properties.py, test_ni_class_4_profits_properties.py, test_trading_allowance_properties.py, test_bus_fare_reforms.py, test_ni_class_4_maximum.py). So it loads the model again for every Simulation. On a loaded host, an unmodified local run reached 3 tests in 90 minutes. With the fixture applied to every test, all 14 passed in 2,035 s.
  3. Changelog fragment example. docs/engineering/skills/github-prs.md (lines 43-48) shows a fragment that starts with - . [tool.towncrier] sets no template, so towncrier's default template adds the bullet itself, and such fragments render as - - in CHANGELOG.md. There are 94 such lines on main, including in 2.122.2 and 2.121.0. Drop the - from the example. Optionally, normalise the existing - - lines.
Dominant language
Python
Stars
50
Forks
34
Avg merge
2d 7h
Merged PRs (30d)
113

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from PolicyEngine/policyengine-uk

All issues in PolicyEngine/policyengine-uk

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.