Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard route

未关闭
#93 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
49/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
typescript

调研方向

Start by tracing the SNI route lookup, failoverIngress forwarding, spilled connection handling, and load query code; the issue does not name files or tests. Reproduce the rolling-upgrade cases with an older peer and mixed-case SNI, then check the reload case with a respelled key in the same metrics group. Done when the issue is either resolved or explicitly accepted for the upgrade window, and the rollout behavior is documented.

由索引模型根据 Issue 内容生成。

描述

During a rolling upgrade to the release with case-insensitive SNI matching, an upgraded node can forward a client's raw ClientHello to a peer's failoverIngress that still runs an older release. The older peer matches the SNI byte for byte, so a mixed-case name (API.example.com) can miss its exact route there and reach a wildcard route instead. The same applies to a spilled connection. The upgraded node chose the peer because of its own lookup of the exact route.

A second effect, in the same window: if both peers serve api.example.com and a reload respells it API.example.com in the same metrics group, the upgraded node keeps the installed spelling and keeps asking for api.example.com in its load query. The older peer now holds the raw key API.example.com, answers -, and spill to it stops. Nothing misroutes.

Both last only until every peer runs the new release. The first needs a client that sends uppercase SNI (browsers never do). Track it so a rollout can either accept it or upgrade failover peers together; close once the fleet is on the release.

Review-Deferral: f7682bdfe0600c53 severity=minor category=correctness
Review-Deferral: 7ce6fa47d6346898 severity=minor category=reliability

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

主要语言
TypeScript
星标
1
派生
0
平均合并
11 小时 49 分钟
30 天内合并 PR
12

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

HarperFast/symphony 的其他 Issue

查看 HarperFast/symphony 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。