Cert carry-forward keeps the previous tenant's upstream when a reload reassigns the route

未关闭
#90 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust
领域
backend, security

调研方向

Start in router.rs at build_route_table (lines 766–781), where the previous route is carried forward after a certificate build failure. Compare the new spec’s metricsGroup with the previous route’s and follow the existing tombstone behavior for a changed client-certificate policy. Done when a tenant change cannot keep forwarding to the previous upstream while its certificate is building; check the related router tests for this reload path.

由索引模型根据 Issue 内容生成。

描述

When a route's cert fails to build on a reload, build_route_table carries the previous route forward whole, upstreams included (router.rs:766-781). The only gate is that the client-certificate policy is unchanged. So a reload that moves an SNI to another tenant (a new metricsGroup and a new upstream) while its new cert is mid-rotation keeps sending that name's traffic to the previous tenant's upstream, under the new tenant's allowedSources, until the cert builds.

The code comment accepts this cost for a cert rotation, where the upstream is the same tenant's. It is a different trade when ownership changes. Suggested fix: do not carry forward when the spec's metricsGroup differs from the previous route's; tombstone the SNI instead, as a changed client-cert policy already does.

Found during review of the SNI case-insensitivity change, which lets a respelled route (API.example.com for api.example.com) reach this path too.

Review-Deferral: 04da97247dd082dc severity=minor category=security

🤖 Generated by Claude Code (Claude Opus 5.5); posted via @dawsontoth.

主要语言
TypeScript
星标
1
派生
0
平均合并
11 小时 49 分钟
30 天内合并 PR
12

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

HarperFast/symphony 的其他 Issue

查看 HarperFast/symphony 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。