Decide whether tlsHandshakeTimeoutMs should cover the ClientHello peek
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- rust
- Domain
- networking
Research direction
Read the timeout handling in src/sni.rs, src/proxy_conn.rs, and src/failover.rs, along with the README’s description of tlsHandshakeTimeoutMs. Decide whether the setting covers only the TLS handshake or total connection setup; then either document that meaning or carry an accept-time deadline through the three paths, accounting for the ClientHello peek. Done means the timeout behavior and its documented meaning agree.
Written by the indexing model from the issue text.
Description
tlsHandshakeTimeoutMs starts counting after the ClientHello peek, so a client's total wait from accept can exceed it by up to the peek's own 5 s limit.
Every user of the timeout starts from the same point, after sni::peek (REASSEMBLY_TIMEOUT in src/sni.rs):
- the TLS handshake:
timeout(hs_timeout, tls_accept(..))insrc/proxy_conn.rs - peer forwarding:
forward_to_peersinsrc/failover.rs - the passthrough local connect plus peer forward from Forward a connection to a peer when its local upstream connect fails (#79)
Nothing is wrong if the setting means "time for the handshake". If an operator reads it as a cap on total connection setup, it is not one. Decide which it means. Then either state it in the README, or start one deadline at accept and deduct the peek time in all three places.
Review-Deferral: 13616fe4f6c36296 severity=nit category=reliability
🤖 Generated by Claude Opus; posted via @kriszyp.
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 0
- Avg merge
- 11h 49m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from HarperFast/symphony
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/symphony#91 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
HarperFast/symphony#89 ·
Maintainers usually reply within 1 day
-
Mixed-case SNI forwarded to an older peer during a rolling upgrade can reach its wildcard routeOpen
Difficulty 4/5 3-5 days Newbie friendliness 49/100
HarperFast/symphony#93 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
HarperFast/symphony#92 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 72/100
HarperFast/symphony#90 ·
Maintainers usually reply within 1 day
All issues in HarperFast/symphony
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Maintainers usually reply within 1 day
-
feature request needs triage
Difficulty 1/5 1-3 hours Newbie friendliness 69/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
solidjs/solid-docs#1716 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
thecodacus/pithagoras#380 ·
Maintainers usually reply within 1 day