Decide whether tlsHandshakeTimeoutMs should cover the ClientHello peek

Open
#80 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
networking

Research direction

Read the timeout handling in src/sni.rs, src/proxy_conn.rs, and src/failover.rs, along with the README’s description of tlsHandshakeTimeoutMs. Decide whether the setting covers only the TLS handshake or total connection setup; then either document that meaning or carry an accept-time deadline through the three paths, accounting for the ClientHello peek. Done means the timeout behavior and its documented meaning agree.

Written by the indexing model from the issue text.

Description

tlsHandshakeTimeoutMs starts counting after the ClientHello peek, so a client's total wait from accept can exceed it by up to the peek's own 5 s limit.

Every user of the timeout starts from the same point, after sni::peek (REASSEMBLY_TIMEOUT in src/sni.rs):

Nothing is wrong if the setting means "time for the handshake". If an operator reads it as a cap on total connection setup, it is not one. Decide which it means. Then either state it in the README, or start one deadline at accept and deduct the peek time in all three places.

Review-Deferral: 13616fe4f6c36296 severity=nit category=reliability

🤖 Generated by Claude Opus; posted via @kriszyp.

Dominant language
TypeScript
Stars
1
Forks
0
Avg merge
11h 49m
Merged PRs (30d)
12

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from HarperFast/symphony

All issues in HarperFast/symphony

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.