Virtualize the remaining full-row lists: Beteiligte, Dateien, Kontakte and the phone card lists
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- android, csharp
- Domain
- frontend, mobile, performance
Research direction
Start with #687 and its VirtualizingStackPanel implementation, then inspect the named lists: EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards, InvolvedPartiesList, ContactsList, and FilesList. Work module by module, beginning with the phone Atemschutz and Kräfte cards; check AGENTS.md for layout traps and preserve row keyboard navigation. For each changed list, done means timings stay flat from N=25 to N=200, Tab and Enter work across scrolled rows, and phone card lists have before and after screenshots.
Written by the indexing model from the issue text.
Description
Problem
#688 (for #685) removed the Workspace container queries, so leaving a module now costs time linear in its number of rows, where it used to be quadratic. But several lists still build every row, whether it is on screen or not, so opening and leaving them still grows with the data:
| List | Module | Grows with |
|---|---|---|
InvolvedPartiesList |
Beteiligte | Beteiligte (~50 visuals per row, 3 TextBoxes) |
FilesList |
Dateien | the incident's files (~30 visuals per row) |
ContactsList |
Kontakte | Stammdaten personnel (~25 visuals per row); a Kreis-wide roster can run into the thousands |
EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards |
phone layout (≤ 640 px) | the same data the desktop DataGrids virtualize |
MatrixRowsList |
CO-Messprotokoll | floors × dwellings; usually small, so lowest priority |
The desktop ETB, Kräfte, Funktionen, Aufgaben and Atemschutz grids are DataGrids and already virtualize. They stay flat and are out of scope here.
Measurements
These come from the measurement on #685 (comment) and from #688.
Setup:
- headless, Release, inside the real
MainView; - median of 3 warm rounds;
- about 40–60 ms of every switch is the harness's own CPU rendering.
Results:
- Leaving a module with the queries gone (desktop): Beteiligte takes 291 ms at N=200, Dateien 184 ms and Kontakte 122 ms. That is acceptable, but it still scales with N.
- Opening a module costs the same with or without the queries; it is plain row building. Opening Atemschutz in the phone layout with 200 Trupps still takes about 2 s.
- Those times come from a desktop CPU running the phone layout. Real Android hardware is slower.
Proposal
Virtualize each of these lists the way #687 did for the Stammdaten Fahrzeuge and Personal lists: an ItemsControl/ListBox over a VirtualizingStackPanel inside a ScrollViewer with a bounded height.
Do it module by module, worst first:
- the phone card lists, Atemschutz and Kräfte first (the Android Lagebuch);
- Beteiligte;
- Kontakte;
- Dateien;
- CO-Messprotokoll, only if it ever shows up.
Traps known from #687
- Tab order breaks in virtualized lists.
- After
ScrollIntoView,VirtualizingStackPanel's children are no longer in visual order, so Tab jumps backwards. - #687 fixed this with
RowTabNavigation, which ranks rows byTabIndex. - Beteiligte rows hold editable TextBoxes, so Tab through them must keep working.
- After
- No content-sized columns over a virtualized list.
- A column with
MaxWidthandHorizontalAlignment="Center"changes width while the user scrolls. - Use
Stretchinstead (see AGENTS.md, Layout traps).
- A column with
- Shared column widths. Row
Grids in anItemsControlneedGrid.IsSharedSizeScopewithSharedSizeGroup. Rows that are not realized yet do not take part, so the widths have to be fixed or bounded rather thanAuto. - Tests that walk the visual tree for rows only see the realized ones once a list virtualizes. Such tests need a tall enough window or a scroll step.
Acceptance
For each list that is changed:
- open and leave times stay flat from N=25 to N=200, with numbers in the PR;
- keyboard navigation (Tab, and Enter where used) works across rows, including rows scrolled into view;
- a before/after phone screenshot for any card list.
- Dominant language
- C#
- Stars
- 1
- Forks
- 3
- Avg merge
- 4h 15m
- Merged PRs (30d)
- 181
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeForFire/lagebuch
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its columnPossibly taken @Saad-elnagar claimed this 2 days ago. Openbug ux
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeForFire/lagebuch#714 · 1 comment ·
Maintainers usually reply within 1 day
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothingPossibly taken @Saad-elnagar claimed this 2 days ago. Openbug ux
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
CodeForFire/lagebuch#713 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
CodeForFire/lagebuch#405 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#349 ·
Maintainers usually reply within 1 day
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
CodeForFire/lagebuch#348 ·
Maintainers usually reply within 1 day
All issues in CodeForFire/lagebuch
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Nimblesite/SharpLsp#468 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
elastic/ecs-dotnet#575 ·
-
alerts bug effort:S P2
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
nightscout/nocturne#2511 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 2 days
-
Crash in v3.00Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
arkane-systems/mousejiggler#140 ·