Virtualize the remaining full-row lists: Beteiligte, Dateien, Kontakte and the phone card lists
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- android, csharp
- 领域
- frontend, mobile, performance
调研方向
Start with #687 and its VirtualizingStackPanel implementation, then inspect the named lists: EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards, InvolvedPartiesList, ContactsList, and FilesList. Work module by module, beginning with the phone Atemschutz and Kräfte cards; check AGENTS.md for layout traps and preserve row keyboard navigation. For each changed list, done means timings stay flat from N=25 to N=200, Tab and Enter work across scrolled rows, and phone card lists have before and after screenshots.
由索引模型根据 Issue 内容生成。
描述
Problem
#688 (for #685) removed the Workspace container queries, so leaving a module now costs time linear in its number of rows, where it used to be quadratic. But several lists still build every row, whether it is on screen or not, so opening and leaving them still grows with the data:
| List | Module | Grows with |
|---|---|---|
InvolvedPartiesList |
Beteiligte | Beteiligte (~50 visuals per row, 3 TextBoxes) |
FilesList |
Dateien | the incident's files (~30 visuals per row) |
ContactsList |
Kontakte | Stammdaten personnel (~25 visuals per row); a Kreis-wide roster can run into the thousands |
EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards |
phone layout (≤ 640 px) | the same data the desktop DataGrids virtualize |
MatrixRowsList |
CO-Messprotokoll | floors × dwellings; usually small, so lowest priority |
The desktop ETB, Kräfte, Funktionen, Aufgaben and Atemschutz grids are DataGrids and already virtualize. They stay flat and are out of scope here.
Measurements
These come from the measurement on #685 (comment) and from #688.
Setup:
- headless, Release, inside the real
MainView; - median of 3 warm rounds;
- about 40–60 ms of every switch is the harness's own CPU rendering.
Results:
- Leaving a module with the queries gone (desktop): Beteiligte takes 291 ms at N=200, Dateien 184 ms and Kontakte 122 ms. That is acceptable, but it still scales with N.
- Opening a module costs the same with or without the queries; it is plain row building. Opening Atemschutz in the phone layout with 200 Trupps still takes about 2 s.
- Those times come from a desktop CPU running the phone layout. Real Android hardware is slower.
Proposal
Virtualize each of these lists the way #687 did for the Stammdaten Fahrzeuge and Personal lists: an ItemsControl/ListBox over a VirtualizingStackPanel inside a ScrollViewer with a bounded height.
Do it module by module, worst first:
- the phone card lists, Atemschutz and Kräfte first (the Android Lagebuch);
- Beteiligte;
- Kontakte;
- Dateien;
- CO-Messprotokoll, only if it ever shows up.
Traps known from #687
- Tab order breaks in virtualized lists.
- After
ScrollIntoView,VirtualizingStackPanel's children are no longer in visual order, so Tab jumps backwards. - #687 fixed this with
RowTabNavigation, which ranks rows byTabIndex. - Beteiligte rows hold editable TextBoxes, so Tab through them must keep working.
- After
- No content-sized columns over a virtualized list.
- A column with
MaxWidthandHorizontalAlignment="Center"changes width while the user scrolls. - Use
Stretchinstead (see AGENTS.md, Layout traps).
- A column with
- Shared column widths. Row
Grids in anItemsControlneedGrid.IsSharedSizeScopewithSharedSizeGroup. Rows that are not realized yet do not take part, so the widths have to be fixed or bounded rather thanAuto. - Tests that walk the visual tree for rows only see the realized ones once a list virtualizes. Such tests need a tall enough window or a scroll step.
Acceptance
For each list that is changed:
- open and leave times stay flat from N=25 to N=200, with numbers in the PR;
- keyboard navigation (Tab, and Enter where used) works across rows, including rows scrolled into view;
- a before/after phone screenshot for any card list.
- 主要语言
- C#
- 星标
- 1
- 派生
- 3
- 平均合并
- 4 小时 15 分钟
- 30 天内合并 PR
- 181
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
CodeForFire/lagebuch 的其他 Issue
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its column可能已有人在做 @Saad-elnagar 于 2 天前认领。 未关闭bug ux
难度 2/5 1-3 小时 新手友好度 78/100
CodeForFire/lagebuch#714 · 1 条评论 ·
维护者通常 1 天内回复
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothing可能已有人在做 @Saad-elnagar 于 2 天前认领。 未关闭bug ux
难度 2/5 1-3 小时 新手友好度 75/100
CodeForFire/lagebuch#713 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 62/100
CodeForFire/lagebuch#405 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 88/100
CodeForFire/lagebuch#349 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 1-3 小时 新手友好度 88/100
CodeForFire/lagebuch#348 ·
维护者通常 1 天内回复
查看 CodeForFire/lagebuch 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
Nimblesite/SharpLsp#468 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
elastic/ecs-dotnet#575 ·
-
alerts bug effort:S P2
难度 2/5 1-3 小时 新手友好度 76/100
nightscout/nocturne#2511 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 2 天内回复
-
Crash in v3.00未关闭
难度 2/5 1-3 小时 新手友好度 62/100
arkane-systems/mousejiggler#140 ·