Virtualize the remaining full-row lists: Beteiligte, Dateien, Kontakte and the phone card lists
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- android, csharp
- Ambito
- frontend, mobile, performance
Direzione di ricerca
Start with #687 and its VirtualizingStackPanel implementation, then inspect the named lists: EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards, InvolvedPartiesList, ContactsList, and FilesList. Work module by module, beginning with the phone Atemschutz and Kräfte cards; check AGENTS.md for layout traps and preserve row keyboard navigation. For each changed list, done means timings stay flat from N=25 to N=200, Tab and Enter work across scrolled rows, and phone card lists have before and after screenshots.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
#688 (for #685) removed the Workspace container queries, so leaving a module now costs time linear in its number of rows, where it used to be quadratic. But several lists still build every row, whether it is on screen or not, so opening and leaving them still grows with the data:
| List | Module | Grows with |
|---|---|---|
InvolvedPartiesList |
Beteiligte | Beteiligte (~50 visuals per row, 3 TextBoxes) |
FilesList |
Dateien | the incident's files (~30 visuals per row) |
ContactsList |
Kontakte | Stammdaten personnel (~25 visuals per row); a Kreis-wide roster can run into the thousands |
EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards |
phone layout (≤ 640 px) | the same data the desktop DataGrids virtualize |
MatrixRowsList |
CO-Messprotokoll | floors × dwellings; usually small, so lowest priority |
The desktop ETB, Kräfte, Funktionen, Aufgaben and Atemschutz grids are DataGrids and already virtualize. They stay flat and are out of scope here.
Measurements
These come from the measurement on #685 (comment) and from #688.
Setup:
- headless, Release, inside the real
MainView; - median of 3 warm rounds;
- about 40–60 ms of every switch is the harness's own CPU rendering.
Results:
- Leaving a module with the queries gone (desktop): Beteiligte takes 291 ms at N=200, Dateien 184 ms and Kontakte 122 ms. That is acceptable, but it still scales with N.
- Opening a module costs the same with or without the queries; it is plain row building. Opening Atemschutz in the phone layout with 200 Trupps still takes about 2 s.
- Those times come from a desktop CPU running the phone layout. Real Android hardware is slower.
Proposal
Virtualize each of these lists the way #687 did for the Stammdaten Fahrzeuge and Personal lists: an ItemsControl/ListBox over a VirtualizingStackPanel inside a ScrollViewer with a bounded height.
Do it module by module, worst first:
- the phone card lists, Atemschutz and Kräfte first (the Android Lagebuch);
- Beteiligte;
- Kontakte;
- Dateien;
- CO-Messprotokoll, only if it ever shows up.
Traps known from #687
- Tab order breaks in virtualized lists.
- After
ScrollIntoView,VirtualizingStackPanel's children are no longer in visual order, so Tab jumps backwards. - #687 fixed this with
RowTabNavigation, which ranks rows byTabIndex. - Beteiligte rows hold editable TextBoxes, so Tab through them must keep working.
- After
- No content-sized columns over a virtualized list.
- A column with
MaxWidthandHorizontalAlignment="Center"changes width while the user scrolls. - Use
Stretchinstead (see AGENTS.md, Layout traps).
- A column with
- Shared column widths. Row
Grids in anItemsControlneedGrid.IsSharedSizeScopewithSharedSizeGroup. Rows that are not realized yet do not take part, so the widths have to be fixed or bounded rather thanAuto. - Tests that walk the visual tree for rows only see the realized ones once a list virtualizes. Such tests need a tall enough window or a scroll step.
Acceptance
For each list that is changed:
- open and leave times stay flat from N=25 to N=200, with numbers in the PR;
- keyboard navigation (Tab, and Enter where used) works across rows, including rows scrolled into view;
- a before/after phone screenshot for any card list.
- Lingua principale
- C#
- Stelle
- 1
- Fork
- 3
- Merge medio
- 4h 49m
- PR unite (30g)
- 177
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di CodeForFire/lagebuch
-
Stammdaten: in the Checkliste editor the PFLICHT header is not aligned with its columnForse già presa @Saad-elnagar l’ha presa 1 giorno fa. Apertabug ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
CodeForFire/lagebuch#714 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Stammdaten: on a phone the Fahrzeuge editor squeezes Wache and Funkrufname to nothingForse già presa @Saad-elnagar l’ha presa 1 giorno fa. Apertabug ux
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
CodeForFire/lagebuch#713 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 62/100
CodeForFire/lagebuch#405 ·
I maintainer di solito rispondono entro 1 giorno
-
documentation good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
CodeForFire/lagebuch#349 ·
I maintainer di solito rispondono entro 1 giorno
-
documentation good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
CodeForFire/lagebuch#348 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di CodeForFire/lagebuch
Issue simili
-
[Bug]: Revit selector reads process ids 2000-2099 as years (flaky AgentClientTests.AYearOrAProcessIdSelectsTheHost)Forse già presa @Wurschdhaud l’ha presa oggi. Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 83/100
pyrevitlabs/pyRevit#3817 ·
I maintainer di solito rispondono entro 1 giorno
-
bug effort:S P2
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
nightscout/nocturne#2449 ·
I maintainer di solito rispondono entro 1 giorno
-
audit:1 bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
NethermindEth/dotnet-libp2p#395 ·
I maintainer di solito rispondono entro 1 giorno
-
area: client bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
I maintainer di solito rispondono entro 1 giorno
-
bug mcp misleading small
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
I maintainer di solito rispondono entro 1 giorno