Virtualize the remaining full-row lists: Beteiligte, Dateien, Kontakte and the phone card lists
Los mantenedores suelen responder en 1 día
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- android, csharp
- Área
- frontend, mobile, performance
Línea de trabajo
Start with #687 and its VirtualizingStackPanel implementation, then inspect the named lists: EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards, InvolvedPartiesList, ContactsList, and FilesList. Work module by module, beginning with the phone Atemschutz and Kräfte cards; check AGENTS.md for layout traps and preserve row keyboard navigation. For each changed list, done means timings stay flat from N=25 to N=200, Tab and Enter work across scrolled rows, and phone card lists have before and after screenshots.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
#688 (for #685) removed the Workspace container queries, so leaving a module now costs time linear in its number of rows, where it used to be quadratic. But several lists still build every row, whether it is on screen or not, so opening and leaving them still grows with the data:
| List | Module | Grows with |
|---|---|---|
InvolvedPartiesList |
Beteiligte | Beteiligte (~50 visuals per row, 3 TextBoxes) |
FilesList |
Dateien | the incident's files (~30 visuals per row) |
ContactsList |
Kontakte | Stammdaten personnel (~25 visuals per row); a Kreis-wide roster can run into the thousands |
EtbCards, ScbaCards, ForcesCards, RolesCards, TasksCards |
phone layout (≤ 640 px) | the same data the desktop DataGrids virtualize |
MatrixRowsList |
CO-Messprotokoll | floors × dwellings; usually small, so lowest priority |
The desktop ETB, Kräfte, Funktionen, Aufgaben and Atemschutz grids are DataGrids and already virtualize. They stay flat and are out of scope here.
Measurements
These come from the measurement on #685 (comment) and from #688.
Setup:
- headless, Release, inside the real
MainView; - median of 3 warm rounds;
- about 40–60 ms of every switch is the harness's own CPU rendering.
Results:
- Leaving a module with the queries gone (desktop): Beteiligte takes 291 ms at N=200, Dateien 184 ms and Kontakte 122 ms. That is acceptable, but it still scales with N.
- Opening a module costs the same with or without the queries; it is plain row building. Opening Atemschutz in the phone layout with 200 Trupps still takes about 2 s.
- Those times come from a desktop CPU running the phone layout. Real Android hardware is slower.
Proposal
Virtualize each of these lists the way #687 did for the Stammdaten Fahrzeuge and Personal lists: an ItemsControl/ListBox over a VirtualizingStackPanel inside a ScrollViewer with a bounded height.
Do it module by module, worst first:
- the phone card lists, Atemschutz and Kräfte first (the Android Lagebuch);
- Beteiligte;
- Kontakte;
- Dateien;
- CO-Messprotokoll, only if it ever shows up.
Traps known from #687
- Tab order breaks in virtualized lists.
- After
ScrollIntoView,VirtualizingStackPanel's children are no longer in visual order, so Tab jumps backwards. - #687 fixed this with
RowTabNavigation, which ranks rows byTabIndex. - Beteiligte rows hold editable TextBoxes, so Tab through them must keep working.
- After
- No content-sized columns over a virtualized list.
- A column with
MaxWidthandHorizontalAlignment="Center"changes width while the user scrolls. - Use
Stretchinstead (see AGENTS.md, Layout traps).
- A column with
- Shared column widths. Row
Grids in anItemsControlneedGrid.IsSharedSizeScopewithSharedSizeGroup. Rows that are not realized yet do not take part, so the widths have to be fixed or bounded rather thanAuto. - Tests that walk the visual tree for rows only see the realized ones once a list virtualizes. Such tests need a tall enough window or a scroll step.
Acceptance
For each list that is changed:
- open and leave times stay flat from N=25 to N=200, with numbers in the PR;
- keyboard navigation (Tab, and Enter where used) works across rows, including rows scrolled into view;
- a before/after phone screenshot for any card list.
- Lenguaje dominante
- C#
- Estrellas
- 1
- Forks
- 3
- Merge medio
- 4 h 34 min
- PR fusionados (30 d)
- 182
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de CodeForFire/lagebuch
-
bug ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
CodeForFire/lagebuch#714 ·
Los mantenedores suelen responder en 1 día
-
bug ux
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
CodeForFire/lagebuch#713 ·
Los mantenedores suelen responder en 1 día
-
enhancement
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
CodeForFire/lagebuch#405 ·
Los mantenedores suelen responder en 1 día
-
documentation good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
CodeForFire/lagebuch#349 ·
Los mantenedores suelen responder en 1 día
-
documentation good first issue
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
CodeForFire/lagebuch#348 ·
Los mantenedores suelen responder en 1 día
Todos los issues de CodeForFire/lagebuch
Issues similares
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 65/100
KnifeLemon/Filee#363 ·
Los mantenedores suelen responder en 1 día
-
[CI] .trgen-ignore required for several grammars.Posiblemente ocupada @kaby76 la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 72/100
antlr/grammars-v4#5073 ·
Los mantenedores suelen responder en 1 día
-
/api/oauth/introspect emits clientId and tokenType instead of RFC 7662's client_id and token_typeAbiertobug P2
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
nightscout/nocturne#2317 ·
Los mantenedores suelen responder en 1 día
-
[BUG]: Position intent set on a simple order is dropped when it becomes a bracket, OCO or OTO orderPosiblemente ocupada @RaphaelFakhri la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
alpacahq/alpaca-trade-api-csharp#903 ·
Los mantenedores suelen responder en 2 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 64/100
joinrpg/joinrpg-net#5752 ·
Los mantenedores suelen responder en 1 día