Start editing a course by clicking its class in a generated timetable
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start by reading ViewTimeTable.tsx and the existing pencil edit flow referenced in #291; check the open changes in #266 and #283 before editing. Trace how timetable blocks expose course and lab codes, including grouped timetables from #267. Done when clicking a class starts editing the matching course, scrolls to the selection box, and saving regenerates the timetable while preserving filters and returning to timetable 1.
Written by the indexing model from the issue text.
Description
Is your feature request related to a problem? Please describe.
After generating, a student who wants to change a course has to scroll up and find it in Your Courses.
Describe the solution you'd like
- Clicking a class in a generated timetable starts the same edit as the pencil (#291) for that course.
- The page scrolls up to the selection box.
- Save changes then works as in #291: it regenerates, keeps the filters and goes back to timetable 1.
Additional context
Depends on #291.
A timetable block only knows its course code, so lab blocks have to be matched on the lab code (courseCodeLab) too.
Related: #193 asks for clicking the grid on the Slot View page to pick slots. This issue is about generated timetables on the main page, so the two don't overlap.
ViewTimeTable.tsx is changing in other work, so expect merge conflicts:
- #266 (open): splits
ViewTimeTable.tsxinto smaller modules. - #283 (open PR): changes timetable state in
ViewTimeTable.tsx. - #267 (merged): groups timetables with the same slot layout. A click should still open the right course.
Design
- Same edit mode as
Quick modify, pencil pressed(node2558:1338) - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2558-1338
Example
One way to build it (just an idea):
onClickon the class block callsstartEditwith the course's id- Then scroll to the selection box
onClick={() => {
startEdit(courseId);
document.getElementById('start')?.scrollIntoView({ behavior: 'smooth' });
}}
- Dominant language
- TypeScript
- Stars
- 6
- Forks
- 37
- Avg merge
- 14h 30m
- Merged PRs (30d)
- 38
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeChefVIT/ffcs
-
Service worker cache limiter evicts offline fallback pagePossibly taken @Rithish-2914 claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
CodeChefVIT/ffcs#273 ·
Maintainers usually reply within 1 day
-
Shared timetable pages use router.push during render to nonexistent /404 routePossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
CodeChefVIT/ffcs#272 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CodeChefVIT/ffcs#261 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
CodeChefVIT/ffcs#295 ·
Maintainers usually reply within 1 day
-
Edit a course from Your Courses with a pencil buttonPossibly taken @Aiden-Trindade claimed this today. Open
Difficulty 5/5 Over a week Newbie friendliness 43/100
CodeChefVIT/ffcs#291 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in CodeChefVIT/ffcs
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine#428 · 1 comment ·
Maintainers usually reply within 1 day
-
GitLab: a merge request closed without merging keeps the Git toolbar on View MR instead of Create MROpen
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
code-yeongyu/oh-my-openagent#11731 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100