Start editing a course by clicking its class in a generated timetable

Aberta
  • Algo errado?
#292 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

Ninguém assumiu esta issue ainda.

Avaliação

Dificuldade
4/5
Tempo estimado
1-2 dias
Facilidade para iniciantes
48/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
react, typescript
Domínio
frontend

Direção de pesquisa

Start by reading ViewTimeTable.tsx and the existing pencil edit flow referenced in #291; check the open changes in #266 and #283 before editing. Trace how timetable blocks expose course and lab codes, including grouped timetables from #267. Done when clicking a class starts editing the matching course, scrolls to the selection box, and saving regenerates the timetable while preserving filters and returning to timetable 1.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Is your feature request related to a problem? Please describe.

After generating, a student who wants to change a course has to scroll up and find it in Your Courses.

Describe the solution you'd like
  • Clicking a class in a generated timetable starts the same edit as the pencil (#291) for that course.
  • The page scrolls up to the selection box.
  • Save changes then works as in #291: it regenerates, keeps the filters and goes back to timetable 1.
Additional context

Depends on #291.

A timetable block only knows its course code, so lab blocks have to be matched on the lab code (courseCodeLab) too.

Related: #193 asks for clicking the grid on the Slot View page to pick slots. This issue is about generated timetables on the main page, so the two don't overlap.

ViewTimeTable.tsx is changing in other work, so expect merge conflicts:

  • #266 (open): splits ViewTimeTable.tsx into smaller modules.
  • #283 (open PR): changes timetable state in ViewTimeTable.tsx.
  • #267 (merged): groups timetables with the same slot layout. A click should still open the right course.
Design
Example

One way to build it (just an idea):

  • onClick on the class block calls startEdit with the course's id
  • Then scroll to the selection box
onClick={() => {
  startEdit(courseId);
  document.getElementById('start')?.scrollIntoView({ behavior: 'smooth' });
}}
Linguagem predominante
TypeScript
Estrelas
6
Forks
37
Merge médio
11h 13min
PRs com merge (30d)
55

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CodeChefVIT/ffcs

Todas as issues de CodeChefVIT/ffcs

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.