Shared timetable pages use router.push during render to nonexistent /404 route
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 85/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- next.js, react, typescript
- Domain
- frontend
Research direction
Read src/app/share/[shareId]/shared.tsx and src/app/share/[shareId]/shared-mobile.tsx, then check how each handles a missing timetable. Replace the render-time navigation to /404 with Next.js notFound() from next/navigation. Done when both pages use the missing-page handling described in the issue and no longer push during render.
Written by the indexing model from the issue text.
Description
Description:
In shared.tsx and shared-mobile.tsx, if a timetable is not found, the code runs router.push('/404') directly inside the component render body. This violates React rendering rules (Cannot update a component while rendering a different component). Additionally, /404 is not a registered App Router page.
What needs to be done:
- Use Next.js's built-in
notFound()function fromnext/navigationinstead of callingrouter.push('/404')during render.
Files:
src/app/share/[shareId]/shared.tsxsrc/app/share/[shareId]/shared-mobile.tsx
- Dominant language
- TypeScript
- Stars
- 6
- Forks
- 27
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 14
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeChefVIT/ffcs
-
Mobile saved page gives no feedback on Copy Link and hides errorsPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
CodeChefVIT/ffcs#274 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
CodeChefVIT/ffcs#273 ·
Maintainers usually reply within 1 day
-
PDF Download crashes silently when page is refreshedPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
CodeChefVIT/ffcs#271 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
CodeChefVIT/ffcs#261 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
CodeChefVIT/ffcs#295 ·
Maintainers usually reply within 1 day
All issues in CodeChefVIT/ffcs
Similar issues
-
Plugin: sheet music can't be scrolled by hand before playbackPossibly taken @snakajima claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
receptron/jinglescript#51 ·
Maintainers usually reply within 1 day
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Maintainers usually reply within 9 days
-
clawsweeper:needs-maintainer-review clawsweeper:needs-product-decision clawsweeper:no-new-fix-pr clawsweeper:source-repro impact:ux-friction issue-rating: 🦞 diamond lobster P3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
openclaw/openclaw#186424 · 1 comment · 1 reaction ·
Maintainers usually reply within 1 day
-
chore(worker): five module header comments describe the code from before later issues changed itOpenarea:dev U2-later
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
bentleypark/aiwatch#1824 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Pal-AI-Lab/Coopanion#469 ·
Maintainers usually reply within 1 day