Edit a course from Your Courses with a pencil button
Maintainers usually reply within 1 day
@Aiden-Trindade is already working on this.
Since Oct 28, 2026.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 43/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- react, typescript
- Domain
- frontend
Research direction
Start with landing.tsx, FacultySelector.tsx, and the fullCourseData shape; trace how courses are selected, saved, and used to generate timetables. Check the existing slot multi-selector work in #287 and the layout work in #290, and review how faculty priorities are loaded. Done when course edits save at the same list position, cancel cleanly, and regenerate visible timetables while preserving filters.
Written by the indexing model from the issue text.
Description
Scroll down for design
Is your feature request related to a problem? Please describe.
To change a course's slot or faculty, a student deletes it and adds it again. The eye button's popup (#252) only reorders the faculty already picked.
Describe the solution you'd like
A pencil on each course row replaces the eye button and its popup (FacultyPriorityModal). Pressing it puts the selection box into edit mode for that course:
- Domain, Subject and Slot are filled in, with all of the course's slots selected. Lab-only courses get their morning or evening lab choice.
- The course's faculty show as ticked, in their current priority order.
- A yellow "Editing " tag marks the box.
- Reset becomes Cancel and Confirm becomes Save changes.
While editing:
- Domain and Subject are locked. Slot and faculty can change.
- Pressing another course's pencil cancels this edit and starts the new one.
- Deleting the course being edited cancels the edit.
Save changes:
- Replaces the course's slots and faculty with what's in the box, so a removed slot is gone.
- Keeps the course in the same place in Your Courses.
- If timetables were showing, regenerates them, keeps the filters and goes back to timetable 1.
Cancel leaves the course as it was and clears the box.
Each course remembers the school, programme, batch and domain it was added under, and editing uses those even if the navbar chip (#286) shows a different school. For courses saved before this change, look the subject up in the current school first, then in all schools.
Additional context
Needs #287 (Slot becomes a multi-selector) and the side-by-side layout (#290). Related: #285 (school popup), #252 (the popup this replaces).
Things in the current code to watch for:
- Confirming a course that's already in the list merges into it and keeps its old slots (
facultySelectorOnConfirminlanding.tsx), so Save changes can't reuse it as is. - Saved courses (
fullCourseData) don't store a school or domain. FacultySelectoralready re-ticks saved faculty when the subject and slot match a saved course, but it reads from localStorage. The edit can build on it but should read from the course list.QuickModify.tsxis an unused stub that only logs to the console. Please remove it.
FacultySelector.tsx is also being split up in #266, so expect merge conflicts.
Design
- Figma frame:
Quick modify, pencil pressed(node2558:1338), in the sectionfac selection changeson the page "FFCS revamp" - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2558-1338
Example
One way to build it (just an idea):
- Keep an
editingCourseIdinlanding.tsx - Pass the course to
FacultySelectorto fill the form, and swap the button labels while it is set - Save changes replaces the course at the same index
<FacultySelector
editingCourse={selectedCourses.find(c => c.id === editingCourseId)}
onConfirm={editingCourseId ? saveEdit : facultySelectorOnConfirm}
onCancelEdit={() => setEditingCourseId(null)}
/>
- Dominant language
- TypeScript
- Stars
- 6
- Forks
- 37
- Avg merge
- 11h 13m
- Merged PRs (30d)
- 55
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeChefVIT/ffcs
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
CodeChefVIT/ffcs#295 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 1-2 days Newbie friendliness 48/100
CodeChefVIT/ffcs#292 ·
Maintainers usually reply within 1 day
-
Put the selection box and Your Courses side by side and restyle themPossibly taken @Aiden-Trindade claimed this 1 day ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 55/100
CodeChefVIT/ffcs#290 · 1 assignee ·
Maintainers usually reply within 1 day
-
Filter timetables by a class time range and rank by fewest lab daysPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 43/100
CodeChefVIT/ffcs#289 ·
Maintainers usually reply within 1 day
-
Replace the timetable filter pills with one Filters button and popoverPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 4/5 3-5 days Newbie friendliness 42/100
CodeChefVIT/ffcs#288 ·
Maintainers usually reply within 1 day
All issues in CodeChefVIT/ffcs
Similar issues
-
fix(worker): keep normal prepare waiting states failure-freePossibly taken @LichKing-2234 claimed this today. Openagent:codex priority:P1
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AgoraIO-Extensions/agent-infra#3745 ·
Maintainers usually reply within 1 day
-
The five-line work window can drop its oldest line: the per-line byte share ignores the JSON framingPossibly taken @Eapp1e claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
makecindy/cindy#7973 · 1 comment ·
Maintainers usually reply within 1 day
-
community first-timers-only good first issue hacktoberfest help wanted low hanging fruit up-for-grabs
Difficulty 1/5 Under an hour Newbie friendliness 78/100
lingdojo/kana-dojo#33337 · 1 comment · 5 reactions ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
code-yeongyu/senpi#4917 · 1 comment ·
Maintainers usually reply within 1 day