Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Edit a course from Your Courses with a pencil button

未关闭
  • 哪里不对？
#291 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@Aiden-Trindade 已经在做这个了。

开始于 2026年10月28日。

评估

难度
5/5
预计耗时
一周以上
新手友好度
43/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
react, typescript
领域
frontend

调研方向

Start with landing.tsx, FacultySelector.tsx, and the fullCourseData shape; trace how courses are selected, saved, and used to generate timetables. Check the existing slot multi-selector work in #287 and the layout work in #290, and review how faculty priorities are loaded. Done when course edits save at the same list position, cancel cleanly, and regenerate visible timetables while preserving filters.

由索引模型根据 Issue 内容生成。

描述

Scroll down for design

Is your feature request related to a problem? Please describe.

To change a course's slot or faculty, a student deletes it and adds it again. The eye button's popup (#252) only reorders the faculty already picked.

Describe the solution you'd like

A pencil on each course row replaces the eye button and its popup (FacultyPriorityModal). Pressing it puts the selection box into edit mode for that course:

  • Domain, Subject and Slot are filled in, with all of the course's slots selected. Lab-only courses get their morning or evening lab choice.
  • The course's faculty show as ticked, in their current priority order.
  • A yellow "Editing " tag marks the box.
  • Reset becomes Cancel and Confirm becomes Save changes.

While editing:

  • Domain and Subject are locked. Slot and faculty can change.
  • Pressing another course's pencil cancels this edit and starts the new one.
  • Deleting the course being edited cancels the edit.

Save changes:

  • Replaces the course's slots and faculty with what's in the box, so a removed slot is gone.
  • Keeps the course in the same place in Your Courses.
  • If timetables were showing, regenerates them, keeps the filters and goes back to timetable 1.

Cancel leaves the course as it was and clears the box.

Each course remembers the school, programme, batch and domain it was added under, and editing uses those even if the navbar chip (#286) shows a different school. For courses saved before this change, look the subject up in the current school first, then in all schools.

Additional context

Needs #287 (Slot becomes a multi-selector) and the side-by-side layout (#290). Related: #285 (school popup), #252 (the popup this replaces).

Things in the current code to watch for:

  • Confirming a course that's already in the list merges into it and keeps its old slots (facultySelectorOnConfirm in landing.tsx), so Save changes can't reuse it as is.
  • Saved courses (fullCourseData) don't store a school or domain.
  • FacultySelector already re-ticks saved faculty when the subject and slot match a saved course, but it reads from localStorage. The edit can build on it but should read from the course list.
  • QuickModify.tsx is an unused stub that only logs to the console. Please remove it.

FacultySelector.tsx is also being split up in #266, so expect merge conflicts.

Design
Image
Example

One way to build it (just an idea):

  • Keep an editingCourseId in landing.tsx
  • Pass the course to FacultySelector to fill the form, and swap the button labels while it is set
  • Save changes replaces the course at the same index
<FacultySelector
  editingCourse={selectedCourses.find(c => c.id === editingCourseId)}
  onConfirm={editingCourseId ? saveEdit : facultySelectorOnConfirm}
  onCancelEdit={() => setEditingCourseId(null)}
/>
主要语言
TypeScript
星标
6
派生
37
平均合并
11 小时 13 分钟
30 天内合并 PR
55

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

CodeChefVIT/ffcs 的其他 Issue

查看 CodeChefVIT/ffcs 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。