Put the selection box and Your Courses side by side and restyle them
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- figma, react, tailwindcss, typescript
Research direction
Start in landing.tsx and inspect how FacultySelector, CourseCard, and TimetableProvider are arranged; compare the relevant components with the linked Figma frame. Restyle and reposition the desktop selection and course panels, keeping their shared state available as described. Done means the layout and listed controls match the requested design at narrow and wide desktop sizes, with behavior unchanged; mobile and dropdown restyling are out of scope.
Written by the indexing model from the issue text.
Description
Follow the figma design, scroll down to see an image and find its link
Is your feature request related to a problem? Please describe.
Your Courses is a separate full-width block below the selection box (landing.tsx), so a student scrolls between adding a course and checking the list. The faculty panels, the Reset and Confirm buttons and the course rows also don't match the new box style.
Describe the solution you'd like
- The selection box and Your Courses sit next to each other.
- When the screen is too narrow for both at the design's sizes, they stack with the selection box on top. The exact width is up to you.
- Your Courses gets the same box style as the selection box.
- Restyle the Select Faculties and Faculty Priority panels, the Reset and Confirm buttons, and the course rows.
- All Subjects Mode and its info button move to the top right of Your Courses, next to the title.
- Remove all moves next to Generate at the bottom.
- The red course priority hint is removed. The info button's popup also says that course order sets priority.
- The eye button stays until #291 replaces it with a pencil.
- Behaviour doesn't change in this issue. The dropdowns are restyled in #287.
Additional context
FacultySelector.tsx is also changed by #285, #287 and #266, so expect merge conflicts.
In landing.tsx, CourseCard is inside TimetableProvider and FacultySelector is not. The edit in #291 needs both to share state, so wrap both in the provider (or keep the shared state in landing.tsx) when moving them.
Mobile uses landing-mobile.tsx and isn't affected.
Design
- Figma frame:
Boxes revamp, All Subjects Mode + Remove all(node2591:1694), in the sectionfac selection changeson the page "FFCS revamp" - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2591-1694
Example
One way to build it (just an idea):
- Put
FacultySelectorandCourseCardin one flex row inlanding.tsx - Move the
BasicToggleButtonand the infoZButtoninto the Your Courses header
<TimetableProvider>
<div className="flex gap-6 items-start">
<FacultySelector onConfirm={facultySelectorOnConfirm} />
<CourseCard selectedCourses={selectedCourses} ... />
</div>
<ViewTimeTable />
</TimetableProvider>
- Dominant language
- TypeScript
- Stars
- 6
- Forks
- 37
- Avg merge
- 11h 13m
- Merged PRs (30d)
- 55
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from CodeChefVIT/ffcs
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
CodeChefVIT/ffcs#295 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 1-2 days Newbie friendliness 48/100
CodeChefVIT/ffcs#292 ·
Maintainers usually reply within 1 day
-
Edit a course from Your Courses with a pencil buttonPossibly taken @Aiden-Trindade claimed this 5 days ago. Open
Difficulty 5/5 Over a week Newbie friendliness 43/100
CodeChefVIT/ffcs#291 · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 43/100
CodeChefVIT/ffcs#289 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
CodeChefVIT/ffcs#288 ·
Maintainers usually reply within 1 day
All issues in CodeChefVIT/ffcs
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
JuliusBrussee/caveman#1449 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
linagora/twake-calendar-frontend#1924 ·
Maintainers usually reply within 1 day
-
Add: Class TV ModaOpencheck:passed streams:add
Difficulty 1/5 Under an hour Newbie friendliness 65/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
libnativeapi/nativeapi#21 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
GiganticMinecraft/seichi-playguide#183 ·
Maintainers usually reply within 1 day