Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Edit a course from Your Courses with a pencil button

Aberta
  • Algo errado?
#291 0 comentários 0 reações 1 responsável Ver no GitHub

Mantenedores costumam responder em até 1 dia

@Aiden-Trindade já está trabalhando nisso.

Desde 28/10/2026.

Avaliação

Dificuldade
5/5
Tempo estimado
Mais de uma semana
Facilidade para iniciantes
43/100
Tipo de issue
Funcionalidade
Clareza
Claramente especificada
Status de atividade
Ativa
Stack de tecnologia
react, typescript
Domínio
frontend

Direção de pesquisa

Start with landing.tsx, FacultySelector.tsx, and the fullCourseData shape; trace how courses are selected, saved, and used to generate timetables. Check the existing slot multi-selector work in #287 and the layout work in #290, and review how faculty priorities are loaded. Done when course edits save at the same list position, cancel cleanly, and regenerate visible timetables while preserving filters.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

Scroll down for design

Is your feature request related to a problem? Please describe.

To change a course's slot or faculty, a student deletes it and adds it again. The eye button's popup (#252) only reorders the faculty already picked.

Describe the solution you'd like

A pencil on each course row replaces the eye button and its popup (FacultyPriorityModal). Pressing it puts the selection box into edit mode for that course:

  • Domain, Subject and Slot are filled in, with all of the course's slots selected. Lab-only courses get their morning or evening lab choice.
  • The course's faculty show as ticked, in their current priority order.
  • A yellow "Editing " tag marks the box.
  • Reset becomes Cancel and Confirm becomes Save changes.

While editing:

  • Domain and Subject are locked. Slot and faculty can change.
  • Pressing another course's pencil cancels this edit and starts the new one.
  • Deleting the course being edited cancels the edit.

Save changes:

  • Replaces the course's slots and faculty with what's in the box, so a removed slot is gone.
  • Keeps the course in the same place in Your Courses.
  • If timetables were showing, regenerates them, keeps the filters and goes back to timetable 1.

Cancel leaves the course as it was and clears the box.

Each course remembers the school, programme, batch and domain it was added under, and editing uses those even if the navbar chip (#286) shows a different school. For courses saved before this change, look the subject up in the current school first, then in all schools.

Additional context

Needs #287 (Slot becomes a multi-selector) and the side-by-side layout (#290). Related: #285 (school popup), #252 (the popup this replaces).

Things in the current code to watch for:

  • Confirming a course that's already in the list merges into it and keeps its old slots (facultySelectorOnConfirm in landing.tsx), so Save changes can't reuse it as is.
  • Saved courses (fullCourseData) don't store a school or domain.
  • FacultySelector already re-ticks saved faculty when the subject and slot match a saved course, but it reads from localStorage. The edit can build on it but should read from the course list.
  • QuickModify.tsx is an unused stub that only logs to the console. Please remove it.

FacultySelector.tsx is also being split up in #266, so expect merge conflicts.

Design
Image
Example

One way to build it (just an idea):

  • Keep an editingCourseId in landing.tsx
  • Pass the course to FacultySelector to fill the form, and swap the button labels while it is set
  • Save changes replaces the course at the same index
<FacultySelector
  editingCourse={selectedCourses.find(c => c.id === editingCourseId)}
  onConfirm={editingCourseId ? saveEdit : facultySelectorOnConfirm}
  onCancelEdit={() => setEditingCourseId(null)}
/>
Linguagem predominante
TypeScript
Estrelas
6
Forks
37
Merge médio
11h 13min
PRs com merge (30d)
55

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de CodeChefVIT/ffcs

Todas as issues de CodeChefVIT/ffcs

Issues semelhantes

Mais issues de TypeScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.