Put the selection box and Your Courses side by side and restyle them
Maintainer antworten meist innerhalb von 1 Tag
Bewertung
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Anfängerfreundlichkeit
- 55/100
- Issue-Typ
- Feature
- Klarheit
- Klar beschrieben
- Aktivitätsstatus
- Aktiv
- Tech-Stack
- figma, react, tailwindcss, typescript
Rechercherichtung
Start in landing.tsx and inspect how FacultySelector, CourseCard, and TimetableProvider are arranged; compare the relevant components with the linked Figma frame. Restyle and reposition the desktop selection and course panels, keeping their shared state available as described. Done means the layout and listed controls match the requested design at narrow and wide desktop sizes, with behavior unchanged; mobile and dropdown restyling are out of scope.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Beschreibung
Follow the figma design, scroll down to see an image and find its link
Is your feature request related to a problem? Please describe.
Your Courses is a separate full-width block below the selection box (landing.tsx), so a student scrolls between adding a course and checking the list. The faculty panels, the Reset and Confirm buttons and the course rows also don't match the new box style.
Describe the solution you'd like
- The selection box and Your Courses sit next to each other.
- When the screen is too narrow for both at the design's sizes, they stack with the selection box on top. The exact width is up to you.
- Your Courses gets the same box style as the selection box.
- Restyle the Select Faculties and Faculty Priority panels, the Reset and Confirm buttons, and the course rows.
- All Subjects Mode and its info button move to the top right of Your Courses, next to the title.
- Remove all moves next to Generate at the bottom.
- The red course priority hint is removed. The info button's popup also says that course order sets priority.
- The eye button stays until #291 replaces it with a pencil.
- Behaviour doesn't change in this issue. The dropdowns are restyled in #287.
Additional context
FacultySelector.tsx is also changed by #285, #287 and #266, so expect merge conflicts.
In landing.tsx, CourseCard is inside TimetableProvider and FacultySelector is not. The edit in #291 needs both to share state, so wrap both in the provider (or keep the shared state in landing.tsx) when moving them.
Mobile uses landing-mobile.tsx and isn't affected.
Design
- Figma frame:
Boxes revamp, All Subjects Mode + Remove all(node2591:1694), in the sectionfac selection changeson the page "FFCS revamp" - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2591-1694
Example
One way to build it (just an idea):
- Put
FacultySelectorandCourseCardin one flex row inlanding.tsx - Move the
BasicToggleButtonand the infoZButtoninto the Your Courses header
<TimetableProvider>
<div className="flex gap-6 items-start">
<FacultySelector onConfirm={facultySelectorOnConfirm} />
<CourseCard selectedCourses={selectedCourses} ... />
</div>
<ViewTimeTable />
</TimetableProvider>
- Vorherrschende Sprache
- TypeScript
- Sterne
- 6
- Forks
- 37
- Ø Merge
- 11 Std. 13 Min.
- Gemergte PRs (30 T.)
- 55
Entwicklungsumgebung
- Kein Dockerfile und keine Docker-Compose-Datei
- Keine Pull-Request-Vorlage
- Beitragsleitfaden lesen
Erste Schritte
- Lesen Sie das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreiben Sie ins Issue, dass Sie es übernehmen — das erspart doppelte Arbeit.
- Forken Sie das Repository und arbeiten Sie in einem Branch.
- Öffnen Sie einen Pull Request, der die Issue-Nummer nennt.
Mehr aus CodeChefVIT/ffcs
-
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 55/100
CodeChefVIT/ffcs#295 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 4/5 1-2 Tage Anfängerfreundlichkeit 48/100
CodeChefVIT/ffcs#292 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Edit a course from Your Courses with a pencil buttonEvtl. vergeben @Aiden-Trindade hat das vor 1 Tag übernommen. Offen
Schwierigkeit 5/5 Über eine Woche Anfängerfreundlichkeit 43/100
CodeChefVIT/ffcs#291 · 1 zugewiesene Person ·
Maintainer antworten meist innerhalb von 1 Tag
-
Filter timetables by a class time range and rank by fewest lab daysEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 43/100
CodeChefVIT/ffcs#289 ·
Maintainer antworten meist innerhalb von 1 Tag
-
Replace the timetable filter pills with one Filters button and popoverEvtl. vergeben Ein verknüpfter Pull Request ist offen oder bereits gemergt. Offen
Schwierigkeit 4/5 3-5 Tage Anfängerfreundlichkeit 42/100
CodeChefVIT/ffcs#288 ·
Maintainer antworten meist innerhalb von 1 Tag
Alle Issues in CodeChefVIT/ffcs
Ähnliche Issues
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 82/100
better-auth/better-auth#12132 · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)Offenbug
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
hurttlocker/o8#5112 ·
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
Maintainer antworten meist innerhalb von 1 Tag
-
Schwierigkeit 2/5 1-3 Stunden Anfängerfreundlichkeit 78/100
webrecorder/wabac.js#386 ·
-
needs-triage
Schwierigkeit 1/5 1-3 Stunden Anfängerfreundlichkeit 92/100
agent-of-empires/agent-of-empires#5098 · 1 Kommentar · 1 Reaktion ·
Maintainer antworten meist innerhalb von 1 Tag