Put the selection box and Your Courses side by side and restyle them
Los mantenedores suelen responder en 1 día
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 55/100
- Tipo de issue
- Nueva funcionalidad
- Claridad
- Bien especificado
- Estado de actividad
- Activo
- Stack tecnológico
- figma, react, tailwindcss, typescript
Línea de trabajo
Start in landing.tsx and inspect how FacultySelector, CourseCard, and TimetableProvider are arranged; compare the relevant components with the linked Figma frame. Restyle and reposition the desktop selection and course panels, keeping their shared state available as described. Done means the layout and listed controls match the requested design at narrow and wide desktop sizes, with behavior unchanged; mobile and dropdown restyling are out of scope.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Follow the figma design, scroll down to see an image and find its link
Is your feature request related to a problem? Please describe.
Your Courses is a separate full-width block below the selection box (landing.tsx), so a student scrolls between adding a course and checking the list. The faculty panels, the Reset and Confirm buttons and the course rows also don't match the new box style.
Describe the solution you'd like
- The selection box and Your Courses sit next to each other.
- When the screen is too narrow for both at the design's sizes, they stack with the selection box on top. The exact width is up to you.
- Your Courses gets the same box style as the selection box.
- Restyle the Select Faculties and Faculty Priority panels, the Reset and Confirm buttons, and the course rows.
- All Subjects Mode and its info button move to the top right of Your Courses, next to the title.
- Remove all moves next to Generate at the bottom.
- The red course priority hint is removed. The info button's popup also says that course order sets priority.
- The eye button stays until #291 replaces it with a pencil.
- Behaviour doesn't change in this issue. The dropdowns are restyled in #287.
Additional context
FacultySelector.tsx is also changed by #285, #287 and #266, so expect merge conflicts.
In landing.tsx, CourseCard is inside TimetableProvider and FacultySelector is not. The edit in #291 needs both to share state, so wrap both in the provider (or keep the shared state in landing.tsx) when moving them.
Mobile uses landing-mobile.tsx and isn't affected.
Design
- Figma frame:
Boxes revamp, All Subjects Mode + Remove all(node2591:1694), in the sectionfac selection changeson the page "FFCS revamp" - Link: https://www.figma.com/design/uCP8B7drfprKgsHYjB8sYs?node-id=2591-1694
Example
One way to build it (just an idea):
- Put
FacultySelectorandCourseCardin one flex row inlanding.tsx - Move the
BasicToggleButtonand the infoZButtoninto the Your Courses header
<TimetableProvider>
<div className="flex gap-6 items-start">
<FacultySelector onConfirm={facultySelectorOnConfirm} />
<CourseCard selectedCourses={selectedCourses} ... />
</div>
<ViewTimeTable />
</TimetableProvider>
- Lenguaje dominante
- TypeScript
- Estrellas
- 6
- Forks
- 37
- Merge medio
- 11 h 13 min
- PR fusionados (30 d)
- 55
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Sin plantilla de pull request
- Leer la guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de CodeChefVIT/ffcs
-
Dificultad 4/5 3-5 días Aptitud para principiantes 55/100
CodeChefVIT/ffcs#295 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 1-2 días Aptitud para principiantes 48/100
CodeChefVIT/ffcs#292 ·
Los mantenedores suelen responder en 1 día
-
Edit a course from Your Courses with a pencil buttonPosiblemente ocupada @Aiden-Trindade la tomó hace 2 días. Abierto
Dificultad 5/5 Más de una semana Aptitud para principiantes 43/100
CodeChefVIT/ffcs#291 · 1 asignado ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 43/100
CodeChefVIT/ffcs#289 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 4/5 3-5 días Aptitud para principiantes 42/100
CodeChefVIT/ffcs#288 ·
Los mantenedores suelen responder en 1 día
Todos los issues de CodeChefVIT/ffcs
Issues similares
-
area:desktop area:ui bug platform:macos
Dificultad 2/5 1-3 horas Aptitud para principiantes 67/100
anthropics/claude-code#106183 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 1/5 1-3 horas Aptitud para principiantes 76/100
Los mantenedores suelen responder en 1 día
-
feature:App-Tour feature:Chat ready Web
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100
digitalfabrik/integreat-app#4523 · 2 reacciones ·
Los mantenedores suelen responder en 3 días
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
Los mantenedores suelen responder en 1 día
-
Required Lexical field accepts two empty paragraphsPosiblemente ocupada @lazerg la tomó hoy. AbiertoBug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
payloadcms/payload#19222 ·
Los mantenedores suelen responder en 1 día