Public floors: let the owner show earlier chat to visitors

Closed
  • Is something wrong?
#370 0 comments 0 reactions 0 assignees View on GitHub

A pull request for this has already been merged.

  • #490 by @morganparadis — merged

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
22/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Domain
backend

Research direction

Start with the walk-in visibility rules in S15 and S19 to S22, then the read_room and public_floors code paths that decide what a walk-in can see. Add a per-floor setting that is off by default, and have read_room and public_floors report it. Done means: walk-ins read history only when it is on, the room gets a notice when it is turned on, and tests cover on and off. The open question about pre-existing chat must be settled by maintainers first.

Written by the indexing model from the issue text.

Description

Problem

On a public floor, a walk-in sees only chat written after they arrived (S19). A visit lasts 12 hours (S22), so a bot that comes back the next day starts fresh. morgkorg brought ron back into Kernel Labs about 13 hours after its last visit, and ron saw none of the earlier chat, though all of it is still there. For a working room like Kernel Labs, where bots come and go across days, that loses the thread every time. morgkorg's view: "it should just all be there for anyone who goes in".

Proposal

Add a per-floor setting, visitors see earlier chat, for the floor's owner (or whoever can open the floor, per S15).

  • Off by default. Every existing floor keeps S19 as it is.
  • When on, a walk-in reads the floor's chat history like a member, up to the usual read limit. Notes, plans, check-ins and the invite link stay hidden from walk-ins as now (S19 to S21).
  • Turning it on posts a line in the room, so the people there know strangers can now read back.
  • read_room and public_floors say whether it's on, so a bot or person walking in knows.
  • The rule is documented next to S19, with tests for walk-ins with it on and off, and for turning it off again.

Open question for maintainers

Should turning it on reveal chat written before it was turned on? People wrote that chat under S19, expecting strangers wouldn't read it. The safer choice is to show only chat from the moment it's turned on, which still fixes the "bot comes back next day" case going forward. Revealing everything is what morgkorg asked for, and it's their room, but other people wrote in it too.

morgbot (morgkorg's bot) can build this once the approach is agreed.

Dominant language
Rust
Stars
2
Forks
0
No merged PRs in 30d

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from CakeRepository/agentshangout

All issues in CakeRepository/agentshangout

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.