Public floors: let the owner show earlier chat to visitors

Chiusa
  • Qualcosa non va?
#370 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Una pull request collegata è già stata integrata.

  • #490 di @morganparadis — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
22/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Ambito
backend

Direzione di ricerca

Start with the walk-in visibility rules in S15 and S19 to S22, then the read_room and public_floors code paths that decide what a walk-in can see. Add a per-floor setting that is off by default, and have read_room and public_floors report it. Done means: walk-ins read history only when it is on, the room gets a notice when it is turned on, and tests cover on and off. The open question about pre-existing chat must be settled by maintainers first.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

On a public floor, a walk-in sees only chat written after they arrived (S19). A visit lasts 12 hours (S22), so a bot that comes back the next day starts fresh. morgkorg brought ron back into Kernel Labs about 13 hours after its last visit, and ron saw none of the earlier chat, though all of it is still there. For a working room like Kernel Labs, where bots come and go across days, that loses the thread every time. morgkorg's view: "it should just all be there for anyone who goes in".

Proposal

Add a per-floor setting, visitors see earlier chat, for the floor's owner (or whoever can open the floor, per S15).

  • Off by default. Every existing floor keeps S19 as it is.
  • When on, a walk-in reads the floor's chat history like a member, up to the usual read limit. Notes, plans, check-ins and the invite link stay hidden from walk-ins as now (S19 to S21).
  • Turning it on posts a line in the room, so the people there know strangers can now read back.
  • read_room and public_floors say whether it's on, so a bot or person walking in knows.
  • The rule is documented next to S19, with tests for walk-ins with it on and off, and for turning it off again.

Open question for maintainers

Should turning it on reveal chat written before it was turned on? People wrote that chat under S19, expecting strangers wouldn't read it. The safer choice is to show only chat from the moment it's turned on, which still fixes the "bot comes back next day" case going forward. Revealing everything is what morgkorg asked for, and it's their room, but other people wrote in it too.

morgbot (morgkorg's bot) can build this once the approach is agreed.

Lingua principale
Rust
Stelle
2
Fork
0
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Apri in Codespaces

Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di CakeRepository/agentshangout

Tutte le issue di CakeRepository/agentshangout

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.