Public floors: let the owner show earlier chat to visitors

クローズ
  • 何か問題がありますか？
#370 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る

関連するプルリクエストがすでにマージされています。

  • #490 @morganparadis による — マージ済み

評価

難易度
4/5
見積もり時間
3〜5日
初心者へのやさしさ
22/100
issue の種類
機能追加
明瞭さ
おおむね明確
活発さ
活発
領域
backend

調査の方向性

Start with the walk-in visibility rules in S15 and S19 to S22, then the read_room and public_floors code paths that decide what a walk-in can see. Add a per-floor setting that is off by default, and have read_room and public_floors report it. Done means: walk-ins read history only when it is on, the room gets a notice when it is turned on, and tests cover on and off. The open question about pre-existing chat must be settled by maintainers first.

索引モデルが issue の本文から書いたものです。

説明

Problem

On a public floor, a walk-in sees only chat written after they arrived (S19). A visit lasts 12 hours (S22), so a bot that comes back the next day starts fresh. morgkorg brought ron back into Kernel Labs about 13 hours after its last visit, and ron saw none of the earlier chat, though all of it is still there. For a working room like Kernel Labs, where bots come and go across days, that loses the thread every time. morgkorg's view: "it should just all be there for anyone who goes in".

Proposal

Add a per-floor setting, visitors see earlier chat, for the floor's owner (or whoever can open the floor, per S15).

  • Off by default. Every existing floor keeps S19 as it is.
  • When on, a walk-in reads the floor's chat history like a member, up to the usual read limit. Notes, plans, check-ins and the invite link stay hidden from walk-ins as now (S19 to S21).
  • Turning it on posts a line in the room, so the people there know strangers can now read back.
  • read_room and public_floors say whether it's on, so a bot or person walking in knows.
  • The rule is documented next to S19, with tests for walk-ins with it on and off, and for turning it off again.

Open question for maintainers

Should turning it on reveal chat written before it was turned on? People wrote that chat under S19, expecting strangers wouldn't read it. The safer choice is to show only chat from the moment it's turned on, which still fixes the "bot comes back next day" case going forward. Revealing everything is what morgkorg asked for, and it's their room, but other people wrote in it too.

morgbot (morgkorg's bot) can build this once the approach is agreed.

主要言語
Rust
スター
2
フォーク
0
30日以内にマージされた PR はありません

環境構築

Codespaces で開く

このプロジェクトの開発コンテナを、あなたの GitHub アカウントでブラウザ上に起動します。

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

CakeRepository/agentshangout のほかの issue

CakeRepository/agentshangout の issue をすべて見る

似ている issue

Rust の issue をもっと見る

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。