Show absorb details in report like other healing actions
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start by tracing how enable_dps_healing=1 populates the generated report’s healing table, then compare that path with the absorb events shown in the debug example. The issue does not name source files or tests, so locate the report and healing-stat entry points first. Done means absorb amounts, such as the example’s Accretion absorb, appear as entries in the healing table.
由索引模型根据 Issue 内容生成。
描述
Is your feature request related to a problem? Please describe.
When simming my character with enable_dps_healing=1 I would like the report to include details about absorb actions as well as heal actions. Currently absorb action stats do not display in the report output.
Not sure if this is a bug or not considering the table in the report does say absorbs as well:
Describe the solution you'd like
Add absorb entries into the healing table in the generated report.
Describe alternatives you've considered
Could also have a separate absorb table, but it being tied to healing matches what is typical for in-game meters.
Additional context
Note below profile example required this PR to be merged to see the absorb: https://github.com/simulationcraft/simc/pull/6173
Sim profile that has an absorb:
priest="Base"
level=60
role=spell
position=back
talents=1111122
spec=shadow
covenant=night_fae
race=goblin
soulbind=dreamweaver:2,319217/283:9:1/107:9:1/319211/114:9:1/66:9:1/319216/319191/115:9:0/352779/69:9:0/352786
enable_dps_healing=1
default_actions=1
head=veil_of_the_banshee_queen,id=186325,ilevel=259,gem_id=173130/187320,bonus_id=6982
neck=interplanar_keystone,id=186379,ilevel=259,gem_id=173130
shoulders=frame_of_the_false_margrave,id=186324,ilevel=259,gem_id=187318
back=drape_of_twisted_loyalties,id=180123,ilevel=252
chest=sacrificers_sacramental_cassock,id=186282,ilevel=252,enchant=eternal_stats,gem_id=187319
wrists=desecrators_keening_wristwraps,id=186321,ilevel=259,gem_id=173130/187315,enchant=eternal_intellect
hands=grasps_of_the_clairvoyant_sage,id=186288,ilevel=252
waist=,id=186284,gem_id=187306,bonus_id=7188/6652/1485/6646
legs=muehzalas_hexthread_sarong,id=179351,bonus_id=7187/1540,ilevel=252
feet=sandals_of_sacred_symmetry,id=186354,ilevel=252
finger1=sworn_oath_of_the_nine,id=186290,ilevel=252,gem_id=173130,enchant=tenet_of_mastery
finger2=death_gods_signet,id=179355,bonus_id=7187/1540/6935,ilevel=252,gem_id=173130,enchant=tenet_of_mastery
trinket1=soulletting_ruby,id=178809,bonus_id=6536/1540/6646,ilevel=252
trinket2=forbidden_necromantic_tome,id=186421,ilevel=259
main_hand=maledict_opus,id=186406,ilevel=259,enchant=sinful_revelation
single_actor_batch=1
optimal_raid=1
desired_targets=1
iterations=10000
Example absorb actions from debug:
0.000 Player 'Base' gains Buff accretion (stacks=1) (value=1154.99275095168)
3.528 Player 'Base' tick amount for Action shadow_word_death_self_damage on Player 'Base': amount=3240 initial_amount=3240 base=3240.473047554532 bonus=0 s_mod=0 s_power=0 a_mod=0 a_power=0 mult=1, tick_mult=1
3.528 Damage to Base after all mitigation is 3132.270000
3.528 Player 'Base' Buff accretion absorbs 1154.99275095168 (remaining: 0)
3.528 Player 'Base' loses Buff accretion
3.528 Damage to Base after accretion is 1977.277249
From the example above you would expect 1154 healing to be attributed to the accretion action in the report.
- 主要语言
- C++
- 星标
- 1.6k
- 派生
- 789
- 平均合并
- 9 小时 44 分钟
- 30 天内合并 PR
- 56
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
simulationcraft/simc 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
simulationcraft/simc#11973 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 69/100
simulationcraft/simc#11747 · 2 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 45/100
simulationcraft/simc#11935 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 68/100
simulationcraft/simc#11918 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
simulationcraft/simc#11845 ·
维护者通常 1 天内回复
查看 simulationcraft/simc 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 85/100
telegramdesktop/tdesktop#31505 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
ll-builder shell completions omit existing lockfile commands and --locked可能已有人在做 @project-nju-learner 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 90/100
OpenAtom-Linyaps/linyaps#2291 ·
维护者通常 1 天内回复