`input` and `output` declarations are unusable
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with Qasm3Visitor._visit_classical_declaration in src/pyqasm/visitor.py, and check how the IODeclaration node from openqasm3 falls through without a scope entry. Reproduce the four failing snippets in the issue, then read tests/qasm3/test_declarations.py. Done means those snippets validate, output can be a measurement target, and dumps() keeps both qualifiers. The binding-versus-symbolic question must be settled by a maintainer before implementation.
由索引模型根据 Issue 内容生成。
描述
Limitation
Input/output defines input and output
modifiers on classical declarations. input marks a value supplied at run time — the spec's
motivating case is a parameterised circuit compiled once and executed many times with
different angles. output marks a value returned to the host.
pyqasm parses both declarations but never registers them in scope. Any later use fails.
Example QASM failure
The spec's own parameterised-circuit pattern:
OPENQASM 3.0;
include "stdgates.inc";
input float[64] a;
qubit[1] q;
rx(a) q[0];
// ValidationError: Invalid parameter 'a' for gate 'rx'
An input used in ordinary classical code fails the same way:
OPENQASM 3.0;
input int[8] a;
int[8] b = a;
// ValidationError: Invalid initialization value for variable 'b'
output is not registered either:
OPENQASM 3.0;
output bit[2] c;
qubit[2] q;
c = measure q;
// ValidationError: Missing register declaration for 'c' in measurement operation
OPENQASM 3.0;
output int[8] c;
c = 1;
// ValidationError: Undefined variable c in assignment
A bare input bit[2] a; with no subsequent use validates cleanly, which confirms the
declaration is parsed and then discarded.
Change Requested
- Register
inputandoutputdeclarations in the global scope with their declared types,
so that every later reference resolves. - An
output-qualified variable must be assignable, including as a measurement target. - Preserve both qualifiers through
dumps()— a round-trip must not silently turn aninput
into an ordinary declaration. - Enforce the spec's scope rule:
inputandoutputare permitted only in global scope.
Open design question
pyqasm's unroller evaluates classical expressions to concrete values, but an input has no
value at analysis time. Two viable directions, and this issue should settle which:
- Binding API — accept values at load or unroll time, e.g.
pyqasm.loads(qasm, inputs={"a": 0.5}), and substitute them during unrolling. Concrete
output, no representation change, but requires the caller to supply every input. - Symbolic passthrough — treat an unbound
inputas an opaque symbol, validate its type
and usage, and emit the expression unevaluated. Keeps the program parameterised at the cost
of expression handling that tolerates non-numeric operands.
Supporting both — bind when a value is given, pass through when it is not — is likely the
right end state, but the first increment should pick one. Maintainer input needed.
Implementation Details
openqasm3exposes the qualifier asIOKeyword.input/IOKeyword.outputon
ClassicalDeclaration/IODeclaration. Confirm which node type the parser produces for
each so the visitor branches correctly.- The declaration path is
Qasm3Visitor._visit_classical_declarationin
src/pyqasm/visitor.py; theIODeclarationnode appears to fall through without a scope
entry. Registering the variable is the minimal fix that clears all four failures above. - The error
"Invalid parameter 'a' for gate 'rx'"comes from the gate-argument evaluation
path — it fires because the identifier does not resolve, so scope registration fixes it
directly under the binding approach, and requires expression-level tolerance under the
symbolic approach. outputneeds the variable marked assignable and visible to the measurement path that
raises"Missing register declaration for 'c' in measurement operation".- Tests:
tests/qasm3/test_declarations.py—inputin a gate argument,inputin classical
arithmetic,outputas a measurement target,outputin a plain assignment, adumps()
round-trip preserving both keywords, andinputdeclared inside adefbody raising a
ValidationError.
- 主要语言
- Python
- 星标
- 29
- 派生
- 33
- 平均合并
- 2 天 4 小时
- 30 天内合并 PR
- 15
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
qBraid/pyqasm 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 63/100
维护者通常 1 天内回复
-
enhancement error-handling program-validation
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
Move the QASM 2 printer and its branch pre-processing out of qasm2.py可能已有人在做 @danielgaskins 于 7 天前认领。 未关闭enhancement qasm2
难度 4/5 3-5 天 新手友好度 22/100
维护者通常 1 天内回复
-
[BUG] dumps() emits extern calls without a semicolon, producing unparsable QASM可能已有人在做 @Jah-yee 于 15 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 25/100
维护者通常 1 天内回复
-
Parse failures raise ValidationError with an empty message; the ANTLR diagnostic is lost可能已有人在做 @tonycoder-hub 于 9 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 22/100
维护者通常 1 天内回复
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 68/100
anchore/grype-db#1149 · 1 条评论 ·
维护者通常 1 天内回复
-
[Bug]: `hermes plugins update` clones an entire monorepo twice - `subdir` is resolved but dropped at both catalog-update call sites可能已有人在做 @HootRock 今天认领。 未关闭comp/cli P2 type/perf
难度 2/5 1-3 小时 新手友好度 72/100
NousResearch/hermes-agent#142417 · 2 条评论 ·
维护者通常 1 天内回复
-
SMC SPEC
难度 2/5 1-3 小时 新手友好度 70/100
tenstorrent/tt-oca-harness#3287 ·
维护者通常 1 天内回复
-
bug enhancement python
难度 2/5 1-3 小时 新手友好度 85/100
DewaldOosthuizen/tech-cheat-sheets-and-notes#392 ·
维护者通常 1 天内回复
-
security
难度 2/5 1-3 小时 新手友好度 72/100
fabriziosalmi/wildbox#801 ·
维护者通常 1 天内回复