`input` and `output` declarations are unusable
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 28/100
Direzione di ricerca
Start with Qasm3Visitor._visit_classical_declaration in src/pyqasm/visitor.py, and check how the IODeclaration node from openqasm3 falls through without a scope entry. Reproduce the four failing snippets in the issue, then read tests/qasm3/test_declarations.py. Done means those snippets validate, output can be a measurement target, and dumps() keeps both qualifiers. The binding-versus-symbolic question must be settled by a maintainer before implementation.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Limitation
Input/output defines input and output
modifiers on classical declarations. input marks a value supplied at run time — the spec's
motivating case is a parameterised circuit compiled once and executed many times with
different angles. output marks a value returned to the host.
pyqasm parses both declarations but never registers them in scope. Any later use fails.
Example QASM failure
The spec's own parameterised-circuit pattern:
OPENQASM 3.0;
include "stdgates.inc";
input float[64] a;
qubit[1] q;
rx(a) q[0];
// ValidationError: Invalid parameter 'a' for gate 'rx'
An input used in ordinary classical code fails the same way:
OPENQASM 3.0;
input int[8] a;
int[8] b = a;
// ValidationError: Invalid initialization value for variable 'b'
output is not registered either:
OPENQASM 3.0;
output bit[2] c;
qubit[2] q;
c = measure q;
// ValidationError: Missing register declaration for 'c' in measurement operation
OPENQASM 3.0;
output int[8] c;
c = 1;
// ValidationError: Undefined variable c in assignment
A bare input bit[2] a; with no subsequent use validates cleanly, which confirms the
declaration is parsed and then discarded.
Change Requested
- Register
inputandoutputdeclarations in the global scope with their declared types,
so that every later reference resolves. - An
output-qualified variable must be assignable, including as a measurement target. - Preserve both qualifiers through
dumps()— a round-trip must not silently turn aninput
into an ordinary declaration. - Enforce the spec's scope rule:
inputandoutputare permitted only in global scope.
Open design question
pyqasm's unroller evaluates classical expressions to concrete values, but an input has no
value at analysis time. Two viable directions, and this issue should settle which:
- Binding API — accept values at load or unroll time, e.g.
pyqasm.loads(qasm, inputs={"a": 0.5}), and substitute them during unrolling. Concrete
output, no representation change, but requires the caller to supply every input. - Symbolic passthrough — treat an unbound
inputas an opaque symbol, validate its type
and usage, and emit the expression unevaluated. Keeps the program parameterised at the cost
of expression handling that tolerates non-numeric operands.
Supporting both — bind when a value is given, pass through when it is not — is likely the
right end state, but the first increment should pick one. Maintainer input needed.
Implementation Details
openqasm3exposes the qualifier asIOKeyword.input/IOKeyword.outputon
ClassicalDeclaration/IODeclaration. Confirm which node type the parser produces for
each so the visitor branches correctly.- The declaration path is
Qasm3Visitor._visit_classical_declarationin
src/pyqasm/visitor.py; theIODeclarationnode appears to fall through without a scope
entry. Registering the variable is the minimal fix that clears all four failures above. - The error
"Invalid parameter 'a' for gate 'rx'"comes from the gate-argument evaluation
path — it fires because the identifier does not resolve, so scope registration fixes it
directly under the binding approach, and requires expression-level tolerance under the
symbolic approach. outputneeds the variable marked assignable and visible to the measurement path that
raises"Missing register declaration for 'c' in measurement operation".- Tests:
tests/qasm3/test_declarations.py—inputin a gate argument,inputin classical
arithmetic,outputas a measurement target,outputin a plain assignment, adumps()
round-trip preserving both keywords, andinputdeclared inside adefbody raising a
ValidationError.
- Lingua principale
- Python
- Stelle
- 29
- Fork
- 33
- Merge medio
- 2g 4h
- PR unite (30g)
- 15
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di qBraid/pyqasm
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
I maintainer di solito rispondono entro 1 giorno
-
enhancement error-handling program-validation
Difficoltà 2/5 1-3 ore Idoneità per principianti 65/100
I maintainer di solito rispondono entro 1 giorno
-
Move the QASM 2 printer and its branch pre-processing out of qasm2.pyForse già presa @danielgaskins l’ha presa 8 giorni fa. Apertaenhancement qasm2
Difficoltà 4/5 3-5 giorni Idoneità per principianti 22/100
qBraid/pyqasm#447 · 2 commenti ·
I maintainer di solito rispondono entro 1 giorno
-
[BUG] dumps() emits extern calls without a semicolon, producing unparsable QASMForse già presa @Jah-yee l’ha presa 16 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 25/100
qBraid/pyqasm#438 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Parse failures raise ValidationError with an empty message; the ANTLR diagnostic is lostForse già presa @tonycoder-hub l’ha presa 9 giorni fa. Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 22/100
qBraid/pyqasm#436 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di qBraid/pyqasm
Issue simili
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
yunaremaia/proto-drift#22 ·
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
yunaremaia/memwatch#96 ·
-
bug good first issue
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 91/100
yunaremaia/ci-gate-watch#34 ·
-
bug good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
yunaremaia/agent-capability-attestation#64 ·
I maintainer di solito rispondono entro 1 giorno
-
bug good first issue
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
yunaremaia/agent-call-graph#43 ·
I maintainer di solito rispondono entro 1 giorno