Slow page loads with many entities: getEntries() checks entities and rights container by container on every request
维护者通常 1 天内回复
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 领域
- backend, performance
调研方向
Start at plugin_init_fields() and PluginFieldsContainer::getEntries(), then inspect getSonsOf() and PluginFieldsProfile::getRightOnContainer() to trace the per-container work. The issue describes the target behavior: compute visibility once per entity and fetch profile rights for visible containers in one query. Compare results across entities and profiles, then measure getEntries(); done means unchanged visibility and rights with lower request time.
由索引模型根据 Issue 内容生成。
描述
Code of Conduct
- I agree to follow this project's Code of Conduct
Is there an existing issue for this?
- I have searched the existing issues
GLPI Version
12.0.1 (same code in the plugin for GLPI 11)
Plugin version
1.25.1 (same code in 1.24.7 on 11.0/bugfixes)
Bug description
plugin_init_fields() calls PluginFieldsContainer::getEntries() on every authenticated request, to register the container tabs. For each active container, getEntries():
- if the container entity is not one of the active entities, calls
getSonsOf()on the container entity and intersects the result with$_SESSION['glpiactiveentities']usingarray_intersect(); - runs one SQL query to get the right of the active profile on the container (
PluginFieldsProfile::getRightOnContainer()).
With containers defined on the root entity (recursive) and users working with many active entities, this becomes expensive. Measured on our instance (22 active containers, all on the root entity, 5591 entities, users with up to 1168 or 5591 active entities): getEntries() takes about 47 ms, on every request, including lightweight AJAX calls (ajax/actorinformation.php, ajax/comments.php, ...). array_intersect() alone costs about 3 ms per container, and the same getSonsOf() result is intersected 22 times.
Since a ticket page sends many AJAX calls at once and they are processed one at a time per session (session lock), this cost adds up to several seconds on the last calls.
Steps To reproduce
- Create about 20 active tab containers on the root entity, recursive.
- Log in with a profile and active entities covering a large entity tree (thousands of entities).
- Measure
PluginFieldsContainer::getEntries(), or the response time of any AJAX endpoint.
Anything else?
This is the same kind of issue as the one fixed in #1187 for findContainer() / findAllContainers(), but on getEntries(), which runs on every request. A fix is proposed in the linked PR: visibility is computed once per entity, and the rights of the profile on all visible containers are read in a single query. Results are unchanged: on our instance, identical for 39 real user/profile combinations and for the 700 profile × container pairs, and getEntries() goes from about 47 ms to about 2 ms (AJAX call from about 240 ms to about 190 ms).
findAllContainers() still calls getRightOnContainer() in a loop and could reuse the same batched query, but it is not called on every request, so it is left out of the PR.
- 主要语言
- PHP
- 星标
- 122
- 派生
- 85
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 20
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
pluginsGLPI/fields 的其他 Issue
-
Value lookups by items_id do not use the itemtype index and scan the whole values table可能已有人在做 @marifex 于 26 天前认领。 未关闭Stale
难度 2/5 1-3 小时 新手友好度 75/100
pluginsGLPI/fields#1310 · 1 条评论 ·
维护者通常 1 天内回复
-
[GLPI 11] GenericObject plugin cannot be migrated. Please update it to the latest version可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 3/5 1-2 天 新手友好度 30/100
pluginsGLPI/fields#1015 ·
维护者通常 1 天内回复
查看 pluginsGLPI/fields 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 1/5 1 小时以内 新手友好度 82/100
pluginsGLPI/carbon#396 ·
-
[BUG] Bundle products lose their price in RSS feeds: getPrices() was removed可能已有人在做 @pcvelz 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 90/100
OpenMage/magento-lts#5869 ·
维护者通常 2 天内回复
-
难度 1/5 1-3 小时 新手友好度 85/100
modelcontextprotocol/php-sdk#746 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
OpenGIS/waymark-wp#82 ·