Slow page loads with many entities: getEntries() checks entities and rights container by container on every request
I maintainer di solito rispondono entro 1 giorno
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 48/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Ambito
- backend, performance
Direzione di ricerca
Start at plugin_init_fields() and PluginFieldsContainer::getEntries(), then inspect getSonsOf() and PluginFieldsProfile::getRightOnContainer() to trace the per-container work. The issue describes the target behavior: compute visibility once per entity and fetch profile rights for visible containers in one query. Compare results across entities and profiles, then measure getEntries(); done means unchanged visibility and rights with lower request time.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Code of Conduct
- I agree to follow this project's Code of Conduct
Is there an existing issue for this?
- I have searched the existing issues
GLPI Version
12.0.1 (same code in the plugin for GLPI 11)
Plugin version
1.25.1 (same code in 1.24.7 on 11.0/bugfixes)
Bug description
plugin_init_fields() calls PluginFieldsContainer::getEntries() on every authenticated request, to register the container tabs. For each active container, getEntries():
- if the container entity is not one of the active entities, calls
getSonsOf()on the container entity and intersects the result with$_SESSION['glpiactiveentities']usingarray_intersect(); - runs one SQL query to get the right of the active profile on the container (
PluginFieldsProfile::getRightOnContainer()).
With containers defined on the root entity (recursive) and users working with many active entities, this becomes expensive. Measured on our instance (22 active containers, all on the root entity, 5591 entities, users with up to 1168 or 5591 active entities): getEntries() takes about 47 ms, on every request, including lightweight AJAX calls (ajax/actorinformation.php, ajax/comments.php, ...). array_intersect() alone costs about 3 ms per container, and the same getSonsOf() result is intersected 22 times.
Since a ticket page sends many AJAX calls at once and they are processed one at a time per session (session lock), this cost adds up to several seconds on the last calls.
Steps To reproduce
- Create about 20 active tab containers on the root entity, recursive.
- Log in with a profile and active entities covering a large entity tree (thousands of entities).
- Measure
PluginFieldsContainer::getEntries(), or the response time of any AJAX endpoint.
Anything else?
This is the same kind of issue as the one fixed in #1187 for findContainer() / findAllContainers(), but on getEntries(), which runs on every request. A fix is proposed in the linked PR: visibility is computed once per entity, and the rights of the profile on all visible containers are read in a single query. Results are unchanged: on our instance, identical for 39 real user/profile combinations and for the 700 profile × container pairs, and getEntries() goes from about 47 ms to about 2 ms (AJAX call from about 240 ms to about 190 ms).
findAllContainers() still calls getRightOnContainer() in a loop and could reuse the same batched query, but it is not called on every request, so it is left out of the PR.
- Lingua principale
- PHP
- Stelle
- 122
- Fork
- 85
- Merge medio
- 1g 15h
- PR unite (30g)
- 20
Preparare l'ambiente
Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di pluginsGLPI/fields
-
Value lookups by items_id do not use the itemtype index and scan the whole values tableForse già presa @marifex l’ha presa 26 giorni fa. ApertaStale
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
pluginsGLPI/fields#1310 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
[GLPI 11] GenericObject plugin cannot be migrated. Please update it to the latest versionForse già presa Una pull request collegata a questa issue è aperta o già unita. Aperta
Difficoltà 3/5 1-2 giorni Idoneità per principianti 30/100
pluginsGLPI/fields#1015 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di pluginsGLPI/fields
Issue simili
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 88/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 82/100
pluginsGLPI/carbon#396 ·
-
[BUG] Bundle products lose their price in RSS feeds: getPrices() was removedForse già presa @pcvelz l’ha presa oggi. Aperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
OpenMage/magento-lts#5869 ·
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 1/5 1-3 ore Idoneità per principianti 85/100
modelcontextprotocol/php-sdk#746 ·
I maintainer di solito rispondono entro 1 giorno
-
Map Info Window ButtonsAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100
OpenGIS/waymark-wp#82 ·