Slow page loads with many entities: getEntries() checks entities and rights container by container on every request

Ouverte
#1,347 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@cgrard y travaille déjà.

Depuis le 12/11/2026.

  • #1348 par @cgrard — ouverte

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
48/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
php, sql
Domaine
backend, performance

Piste de recherche

Start at plugin_init_fields() and PluginFieldsContainer::getEntries(), then inspect getSonsOf() and PluginFieldsProfile::getRightOnContainer() to trace the per-container work. The issue describes the target behavior: compute visibility once per entity and fetch profile rights for visible containers in one query. Compare results across entities and profiles, then measure getEntries(); done means unchanged visibility and rights with lower request time.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Code of Conduct
  • I agree to follow this project's Code of Conduct
Is there an existing issue for this?
  • I have searched the existing issues
GLPI Version

12.0.1 (same code in the plugin for GLPI 11)

Plugin version

1.25.1 (same code in 1.24.7 on 11.0/bugfixes)

Bug description

plugin_init_fields() calls PluginFieldsContainer::getEntries() on every authenticated request, to register the container tabs. For each active container, getEntries():

  • if the container entity is not one of the active entities, calls getSonsOf() on the container entity and intersects the result with $_SESSION['glpiactiveentities'] using array_intersect();
  • runs one SQL query to get the right of the active profile on the container (PluginFieldsProfile::getRightOnContainer()).

With containers defined on the root entity (recursive) and users working with many active entities, this becomes expensive. Measured on our instance (22 active containers, all on the root entity, 5591 entities, users with up to 1168 or 5591 active entities): getEntries() takes about 47 ms, on every request, including lightweight AJAX calls (ajax/actorinformation.php, ajax/comments.php, ...). array_intersect() alone costs about 3 ms per container, and the same getSonsOf() result is intersected 22 times.

Since a ticket page sends many AJAX calls at once and they are processed one at a time per session (session lock), this cost adds up to several seconds on the last calls.

Steps To reproduce
  1. Create about 20 active tab containers on the root entity, recursive.
  2. Log in with a profile and active entities covering a large entity tree (thousands of entities).
  3. Measure PluginFieldsContainer::getEntries(), or the response time of any AJAX endpoint.
Anything else?

This is the same kind of issue as the one fixed in #1187 for findContainer() / findAllContainers(), but on getEntries(), which runs on every request. A fix is proposed in the linked PR: visibility is computed once per entity, and the rights of the profile on all visible containers are read in a single query. Results are unchanged: on our instance, identical for 39 real user/profile combinations and for the 700 profile × container pairs, and getEntries() goes from about 47 ms to about 2 ms (AJAX call from about 240 ms to about 190 ms).

findAllContainers() still calls getRightOnContainer() in a loop and could reuse the same batched query, but it is not called on every request, so it is left out of the PR.

Langage dominant
PHP
Étoiles
122
Forks
85
Merge moyen
1 j 15 h
PR mergées (30 j)
20

Préparer son environnement

Ce projet ne fournit ni conteneur de développement, ni Dockerfile, ni guide de contribution : l'installation est à votre charge. Commencez par son README, et consultez notre guide de la première contribution pour les étapes générales.

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de pluginsGLPI/fields

Toutes les issues de pluginsGLPI/fields

Issues similaires

Plus d'issues PHP

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.