Slow page loads with many entities: getEntries() checks entities and rights container by container on every request
Mantenedores costumam responder em até 1 dia
Avaliação
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Facilidade para iniciantes
- 48/100
- Tipo de issue
- Bug
- Clareza
- Claramente especificada
- Status de atividade
- Ativa
- Domínio
- backend, performance
Direção de pesquisa
Start at plugin_init_fields() and PluginFieldsContainer::getEntries(), then inspect getSonsOf() and PluginFieldsProfile::getRightOnContainer() to trace the per-container work. The issue describes the target behavior: compute visibility once per entity and fetch profile rights for visible containers in one query. Compare results across entities and profiles, then measure getEntries(); done means unchanged visibility and rights with lower request time.
Escrita pelo modelo de indexação a partir do texto da issue.
Descrição
Code of Conduct
- I agree to follow this project's Code of Conduct
Is there an existing issue for this?
- I have searched the existing issues
GLPI Version
12.0.1 (same code in the plugin for GLPI 11)
Plugin version
1.25.1 (same code in 1.24.7 on 11.0/bugfixes)
Bug description
plugin_init_fields() calls PluginFieldsContainer::getEntries() on every authenticated request, to register the container tabs. For each active container, getEntries():
- if the container entity is not one of the active entities, calls
getSonsOf()on the container entity and intersects the result with$_SESSION['glpiactiveentities']usingarray_intersect(); - runs one SQL query to get the right of the active profile on the container (
PluginFieldsProfile::getRightOnContainer()).
With containers defined on the root entity (recursive) and users working with many active entities, this becomes expensive. Measured on our instance (22 active containers, all on the root entity, 5591 entities, users with up to 1168 or 5591 active entities): getEntries() takes about 47 ms, on every request, including lightweight AJAX calls (ajax/actorinformation.php, ajax/comments.php, ...). array_intersect() alone costs about 3 ms per container, and the same getSonsOf() result is intersected 22 times.
Since a ticket page sends many AJAX calls at once and they are processed one at a time per session (session lock), this cost adds up to several seconds on the last calls.
Steps To reproduce
- Create about 20 active tab containers on the root entity, recursive.
- Log in with a profile and active entities covering a large entity tree (thousands of entities).
- Measure
PluginFieldsContainer::getEntries(), or the response time of any AJAX endpoint.
Anything else?
This is the same kind of issue as the one fixed in #1187 for findContainer() / findAllContainers(), but on getEntries(), which runs on every request. A fix is proposed in the linked PR: visibility is computed once per entity, and the rights of the profile on all visible containers are read in a single query. Results are unchanged: on our instance, identical for 39 real user/profile combinations and for the 700 profile × container pairs, and getEntries() goes from about 47 ms to about 2 ms (AJAX call from about 240 ms to about 190 ms).
findAllContainers() still calls getRightOnContainer() in a loop and could reuse the same batched query, but it is not called on every request, so it is left out of the PR.
- Linguagem predominante
- PHP
- Estrelas
- 122
- Forks
- 85
- Merge médio
- 1d 15h
- PRs com merge (30d)
- 20
Preparar o ambiente
Este projeto não oferece contêiner de desenvolvimento, Dockerfile nem guia de contribuição, então a configuração fica por sua conta: comece pelo README e veja nosso guia da primeira contribuição para os passos gerais.
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Mais de pluginsGLPI/fields
-
Value lookups by items_id do not use the itemtype index and scan the whole values tableTalvez já em andamento @marifex assumiu há 26 dias. AbertaStale
Dificuldade 2/5 1-3 horas Facilidade para iniciantes 75/100
pluginsGLPI/fields#1310 · 1 comentário ·
Mantenedores costumam responder em até 1 dia
-
[GLPI 11] GenericObject plugin cannot be migrated. Please update it to the latest versionTalvez já em andamento Um pull request vinculado a esta issue está aberto ou já foi mesclado. Aberta
Dificuldade 3/5 1-2 dias Facilidade para iniciantes 30/100
pluginsGLPI/fields#1015 ·
Mantenedores costumam responder em até 1 dia
Todas as issues de pluginsGLPI/fields
Issues semelhantes
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 88/100
-
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 82/100
pluginsGLPI/carbon#396 ·
-
[BUG] Bundle products lose their price in RSS feeds: getPrices() was removedTalvez já em andamento @pcvelz assumiu hoje. Aberta
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
OpenMage/magento-lts#5869 ·
Mantenedores costumam responder em até 2 dias
-
Dificuldade 1/5 1-3 horas Facilidade para iniciantes 85/100
modelcontextprotocol/php-sdk#746 ·
Mantenedores costumam responder em até 1 dia
-
Map Info Window ButtonsAberta
Dificuldade 1/5 Menos de uma hora Facilidade para iniciantes 90/100
OpenGIS/waymark-wp#82 ·