Integer limit, offset and column values raise TypeError in getSqlString() on a strict platform
维护者通常 1 天内回复
评估
调研方向
Start with the named call sites in src/Sql/Select.php and src/Sql/AbstractSql.php, then read test/unit/TestAsset/TrustingSql92Platform.php and the existing unit tests that exercise these paths. Check how the expression path handles values before quoting. Done means integer and boolean values are safely quoted and the strict test platform catches non-string arguments; the unit suite passes.
由索引模型根据 Issue 内容生成。
描述
Package Version
0.6.x-dev @ e022af5c
Php Version
8.3, 8.4, 8.5
Database Engine
Any platform whose quoteValue() keeps the string type: Sql92, MySQL, SQLite and PostgreSQL (PDO::quote())
Basic Information
PlatformInterface::quoteValue() takes a string (PlatformInterface.php#L68). Three call sites in strict-typed files pass values that can be integers or booleans:
Select::processLimit()passes$this->limit(Select.php#L522), typedstring|int|null.Select::processOffset()passes$this->offset(Select.php#L540).AbstractSql::resolveColumnValue()passes$column(AbstractSql.php#L445), which can beintorbool. Insert and Update values go through it.
The expression path in the same class already casts: quoteValue((string) $argument->getValue()) (AbstractSql.php#L242).
The unit suite does not catch this because TrustingSql92Platform::quoteValue($value) drops the string type (TrustingSql92Platform.php#L16), so it accepts integers.
Prepared statements are unaffected: those paths bind the value instead of quoting it. The MySQL and SQLite driver SelectDecorators render limit and offset without quoting, so only their non-decorated paths are affected.
Steps to Reproduce
(new Select('t'))->limit(10)->getSqlString($platform)with the MySQL or SQLite driver'sAdapterPlatform, or with PostgreSQL's (which has noSelectDecorator).(new Insert('t'))->values(['c' => 1])rendered withbuildSqlString()on the SQLiteAdapterPlatform.
Expected Behavior
Scalars are cast to string before quoting, as the expression path already does: LIMIT '10' and VALUES ('1').
TrustingSql92Platform::quoteValue() should keep the string type, so the suite fails if a call site passes a non-string again. With that change alone, 6 existing tests error.
Actual behavior?
TypeError: PhpDb\Adapter\Platform\Sql92::quoteValue(): Argument #1 ($value) must be of type string, int given, called in src/Sql/Select.php on line 522
On phpdb-pgsql:
TypeError: PDO::quote(): Argument #1 ($string) must be of type string, int given
Additional Info
The same cast was made on the unmerged sql-platform-refactor branch (a0b63fa4, "Fixed small issue where limit/offset were not cast as strings").
- 主要语言
- PHP
- 星标
- 18
- 派生
- 8
- 平均合并
- 6 天 11 小时
- 30 天内合并 PR
- 14
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
php-db/phpdb 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
RFC
难度 3/5 1-2 天 新手友好度 66/100
维护者通常 1 天内回复
-
RFC
难度 5/5 一周以上 新手友好度 38/100
维护者通常 1 天内回复
-
RFC
难度 3/5 1-2 天 新手友好度 68/100
维护者通常 1 天内回复
-
RFC
难度 4/5 3-5 天 新手友好度 45/100
维护者通常 1 天内回复
相似的 Issue
-
Bug Enhancement Performance
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
Feature Status: Needs Triage
难度 2/5 1-3 小时 新手友好度 73/100
维护者通常 1 天内回复
-
frontend low-priority
难度 2/5 1-3 小时 新手友好度 77/100
mplodowski/dynamicpdf-plugin#336 ·
维护者通常 1 天内回复
-
Add Zammad可能已有人在做 @Arslan-TR 今天认领。 未关闭request
难度 2/5 1-3 小时 新手友好度 66/100
endoflife-date/endoflife.date#11298 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
FriendsOfFlarum/best-answer#137 ·