Integer limit, offset and column values raise TypeError in getSqlString() on a strict platform
維護者通常 1 天內回覆
評估
研究方向
Start with the named call sites in src/Sql/Select.php and src/Sql/AbstractSql.php, then read test/unit/TestAsset/TrustingSql92Platform.php and the existing unit tests that exercise these paths. Check how the expression path handles values before quoting. Done means integer and boolean values are safely quoted and the strict test platform catches non-string arguments; the unit suite passes.
由索引模型根據 Issue 內容生成。
描述
Package Version
0.6.x-dev @ e022af5c
Php Version
8.3, 8.4, 8.5
Database Engine
Any platform whose quoteValue() keeps the string type: Sql92, MySQL, SQLite and PostgreSQL (PDO::quote())
Basic Information
PlatformInterface::quoteValue() takes a string (PlatformInterface.php#L68). Three call sites in strict-typed files pass values that can be integers or booleans:
Select::processLimit()passes$this->limit(Select.php#L522), typedstring|int|null.Select::processOffset()passes$this->offset(Select.php#L540).AbstractSql::resolveColumnValue()passes$column(AbstractSql.php#L445), which can beintorbool. Insert and Update values go through it.
The expression path in the same class already casts: quoteValue((string) $argument->getValue()) (AbstractSql.php#L242).
The unit suite does not catch this because TrustingSql92Platform::quoteValue($value) drops the string type (TrustingSql92Platform.php#L16), so it accepts integers.
Prepared statements are unaffected: those paths bind the value instead of quoting it. The MySQL and SQLite driver SelectDecorators render limit and offset without quoting, so only their non-decorated paths are affected.
Steps to Reproduce
(new Select('t'))->limit(10)->getSqlString($platform)with the MySQL or SQLite driver'sAdapterPlatform, or with PostgreSQL's (which has noSelectDecorator).(new Insert('t'))->values(['c' => 1])rendered withbuildSqlString()on the SQLiteAdapterPlatform.
Expected Behavior
Scalars are cast to string before quoting, as the expression path already does: LIMIT '10' and VALUES ('1').
TrustingSql92Platform::quoteValue() should keep the string type, so the suite fails if a call site passes a non-string again. With that change alone, 6 existing tests error.
Actual behavior?
TypeError: PhpDb\Adapter\Platform\Sql92::quoteValue(): Argument #1 ($value) must be of type string, int given, called in src/Sql/Select.php on line 522
On phpdb-pgsql:
TypeError: PDO::quote(): Argument #1 ($string) must be of type string, int given
Additional Info
The same cast was made on the unmerged sql-platform-refactor branch (a0b63fa4, "Fixed small issue where limit/offset were not cast as strings").
- 主要語言
- PHP
- 星號
- 18
- 分支
- 8
- 平均合併
- 6 天 11 小時
- 30 天內合併 PR
- 14
環境準備
- 提供 Dockerfile 或 Docker Compose 檔案
- 沒有 Pull Request 範本
- 沒有貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
php-db/phpdb 的其他 Issue
-
bug
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
RFC
難度 3/5 1-2 天 新手友好度 66/100
維護者通常 1 天內回覆
-
RFC
難度 5/5 一週以上 新手友好度 38/100
維護者通常 1 天內回覆
-
RFC
難度 3/5 1-2 天 新手友好度 68/100
維護者通常 1 天內回覆
-
RFC
難度 4/5 3-5 天 新手友好度 45/100
維護者通常 1 天內回覆
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 68/100
維護者通常 1 天內回覆
-
Awaiting Triage bug
難度 2/5 1-3 小時 新手友好度 65/100
維護者通常 1 天內回覆
-
product / databases
難度 2/5 1-3 小時 新手友好度 82/100
維護者通常 1 天內回覆
-
enhancement
難度 2/5 1-3 小時 新手友好度 75/100
VilnaCRM-Org/user-service#525 ·
維護者通常 21 天內回覆
-
難度 2/5 1-3 小時 新手友好度 68/100
shukiv/jabali-panel#2029 ·
維護者通常 1 天內回覆