Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

Integer limit, offset and column values raise TypeError in getSqlString() on a strict platform

Abierto
  • ¿Algo no está bien?
#205 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@simon-mundy ya está trabajando en esto.

Desde el 5/10/2026.

  • #222 de @simon-mundy — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
php, sql
Área
database

Línea de trabajo

Start with the named call sites in src/Sql/Select.php and src/Sql/AbstractSql.php, then read test/unit/TestAsset/TrustingSql92Platform.php and the existing unit tests that exercise these paths. Check how the expression path handles values before quoting. Done means integer and boolean values are safely quoted and the strict test platform catches non-string arguments; the unit suite passes.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug
Package Version

0.6.x-dev @ e022af5c

Php Version

8.3, 8.4, 8.5

Database Engine

Any platform whose quoteValue() keeps the string type: Sql92, MySQL, SQLite and PostgreSQL (PDO::quote())

Basic Information

PlatformInterface::quoteValue() takes a string (PlatformInterface.php#L68). Three call sites in strict-typed files pass values that can be integers or booleans:

  • Select::processLimit() passes $this->limit (Select.php#L522), typed string|int|null.
  • Select::processOffset() passes $this->offset (Select.php#L540).
  • AbstractSql::resolveColumnValue() passes $column (AbstractSql.php#L445), which can be int or bool. Insert and Update values go through it.

The expression path in the same class already casts: quoteValue((string) $argument->getValue()) (AbstractSql.php#L242).

The unit suite does not catch this because TrustingSql92Platform::quoteValue($value) drops the string type (TrustingSql92Platform.php#L16), so it accepts integers.

Prepared statements are unaffected: those paths bind the value instead of quoting it. The MySQL and SQLite driver SelectDecorators render limit and offset without quoting, so only their non-decorated paths are affected.

Steps to Reproduce
  1. (new Select('t'))->limit(10)->getSqlString($platform) with the MySQL or SQLite driver's AdapterPlatform, or with PostgreSQL's (which has no SelectDecorator).
  2. (new Insert('t'))->values(['c' => 1]) rendered with buildSqlString() on the SQLite AdapterPlatform.
Expected Behavior

Scalars are cast to string before quoting, as the expression path already does: LIMIT '10' and VALUES ('1').

TrustingSql92Platform::quoteValue() should keep the string type, so the suite fails if a call site passes a non-string again. With that change alone, 6 existing tests error.

Actual behavior?
TypeError: PhpDb\Adapter\Platform\Sql92::quoteValue(): Argument #1 ($value) must be of type string, int given, called in src/Sql/Select.php on line 522

On phpdb-pgsql:

TypeError: PDO::quote(): Argument #1 ($string) must be of type string, int given
Additional Info

The same cast was made on the unmerged sql-platform-refactor branch (a0b63fa4, "Fixed small issue where limit/offset were not cast as strings").

Lenguaje dominante
PHP
Estrellas
18
Forks
8
Merge medio
6 d 11 h
PR fusionados (30 d)
14

Preparar el entorno

  • Incluye un Dockerfile o un archivo de Docker Compose
  • Sin plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de php-db/phpdb

Todos los issues de php-db/phpdb

Issues similares

Más issues de PHP

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.