Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Integer limit, offset and column values raise TypeError in getSqlString() on a strict platform

Aberta
  • Algo errado?
#205 0 comentários 0 reações 0 responsáveis Ver no GitHub

Mantenedores costumam responder em até 1 dia

@simon-mundy já está trabalhando nisso.

Desde 5/10/2026.

  • #222 de @simon-mundy — aberto

Avaliação

Dificuldade
2/5
Tempo estimado
1-3 horas
Facilidade para iniciantes
25/100
Tipo de issue
Bug
Clareza
Claramente especificada
Status de atividade
Estagnada
Stack de tecnologia
php, sql
Domínio
database

Direção de pesquisa

Start with the named call sites in src/Sql/Select.php and src/Sql/AbstractSql.php, then read test/unit/TestAsset/TrustingSql92Platform.php and the existing unit tests that exercise these paths. Check how the expression path handles values before quoting. Done means integer and boolean values are safely quoted and the strict test platform catches non-string arguments; the unit suite passes.

Escrita pelo modelo de indexação a partir do texto da issue.

Descrição

bug
Package Version

0.6.x-dev @ e022af5c

Php Version

8.3, 8.4, 8.5

Database Engine

Any platform whose quoteValue() keeps the string type: Sql92, MySQL, SQLite and PostgreSQL (PDO::quote())

Basic Information

PlatformInterface::quoteValue() takes a string (PlatformInterface.php#L68). Three call sites in strict-typed files pass values that can be integers or booleans:

  • Select::processLimit() passes $this->limit (Select.php#L522), typed string|int|null.
  • Select::processOffset() passes $this->offset (Select.php#L540).
  • AbstractSql::resolveColumnValue() passes $column (AbstractSql.php#L445), which can be int or bool. Insert and Update values go through it.

The expression path in the same class already casts: quoteValue((string) $argument->getValue()) (AbstractSql.php#L242).

The unit suite does not catch this because TrustingSql92Platform::quoteValue($value) drops the string type (TrustingSql92Platform.php#L16), so it accepts integers.

Prepared statements are unaffected: those paths bind the value instead of quoting it. The MySQL and SQLite driver SelectDecorators render limit and offset without quoting, so only their non-decorated paths are affected.

Steps to Reproduce
  1. (new Select('t'))->limit(10)->getSqlString($platform) with the MySQL or SQLite driver's AdapterPlatform, or with PostgreSQL's (which has no SelectDecorator).
  2. (new Insert('t'))->values(['c' => 1]) rendered with buildSqlString() on the SQLite AdapterPlatform.
Expected Behavior

Scalars are cast to string before quoting, as the expression path already does: LIMIT '10' and VALUES ('1').

TrustingSql92Platform::quoteValue() should keep the string type, so the suite fails if a call site passes a non-string again. With that change alone, 6 existing tests error.

Actual behavior?
TypeError: PhpDb\Adapter\Platform\Sql92::quoteValue(): Argument #1 ($value) must be of type string, int given, called in src/Sql/Select.php on line 522

On phpdb-pgsql:

TypeError: PDO::quote(): Argument #1 ($string) must be of type string, int given
Additional Info

The same cast was made on the unmerged sql-platform-refactor branch (a0b63fa4, "Fixed small issue where limit/offset were not cast as strings").

Linguagem predominante
PHP
Estrelas
18
Forks
8
Merge médio
6d 11h
PRs com merge (30d)
14

Preparar o ambiente

  • Inclui um Dockerfile ou arquivo Docker Compose
  • Sem modelo de pull request
  • Sem guia de contribuição

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de php-db/phpdb

Todas as issues de php-db/phpdb

Issues semelhantes

Mais issues de PHP

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.