Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Migrate generate-automation.js to js-yaml 5

未关闭
#122 1 条评论 1 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@rtibblesbot 已经在做这个了。

开始于 2026年10月25日。

  • #125 来自 @rtibblesbot —— 未关闭

评估

这个 Issue 还没有评估数据。

描述

community-contribution-in-progress dependencies javascript

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Dependabot PR #118 bumps the js-yaml devDependency from 4.1.0 to 5.5.0 and was closed unmerged: under 5.x, scripts/generate-automation.js emits different YAML, so the generate-automation prek hook (node scripts/generate-automation.js --check) fails on all five generated files. The generator needs to produce the current output under js-yaml 5 before the bump can land.

Complexity: Low
Target branch: main

Context
  • js-yaml 5.4.0 reworked scalar style selection and rewrote sortKeys.
  • DUMP_OPTS sets quotingType: '"'; under 5.5.0 strings come out single-quoted anyway.
  • The top-level on key now dumps as 'on':; unquoteOnKey only matches "on":, so the key stays quoted and the # zizmor: ignore[dangerous-triggers] suffix is dropped from automation-caller.yml.
  • The bump also adds argparse@^3.0.3 as a transitive dependency; no other package must move with it.
The Change
  • js-yaml should be upgraded to 5.5.0 or later in package.json and yarn.lock.
  • The generator should select double-quoted strings through the js-yaml 5 scalar style options (5.4.0 added scalarStyleRules).
  • unquoteOnKey should match the on key as js-yaml 5 emits it.
How to Get There

Install the dependency branch from #118 (dependabot/npm_and_yarn/js-yaml-5.5.0), then run node scripts/generate-automation.js --check.

Acceptance Criteria
  • package.json and yarn.lock pin js-yaml at 5.5.0 or later.
  • node scripts/generate-automation.js --check passes, and the prek CI job is green.
  • automation.yml, automation-caller.yml, automation-group-issues.yml, automation-group-pull-request-target.yml and automation-template.yml keep double-quoted strings and a bare on: key.
  • automation-caller.yml keeps on: # zizmor: ignore[dangerous-triggers].
  • Any remaining diff in the generated files is committed alongside the generator change.
References

AI usage

rtibblesbot (Claude Code) reviewed #118, recommended closing it, and drafted this issue from that review.

Filed from #118's review.

主要语言
JavaScript
星标
1
派生
7
平均合并
2 天 8 小时
30 天内合并 PR
10

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

learningequality/.github 的其他 Issue

查看 learningequality/.github 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。