Migrate generate-automation.js to js-yaml 5
维护者通常 1 天内回复
评估
这个 Issue 还没有评估数据。
描述
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Overview
Dependabot PR #118 bumps the js-yaml devDependency from 4.1.0 to 5.5.0 and was closed unmerged: under 5.x, scripts/generate-automation.js emits different YAML, so the generate-automation prek hook (node scripts/generate-automation.js --check) fails on all five generated files. The generator needs to produce the current output under js-yaml 5 before the bump can land.
Complexity: Low
Target branch: main
Context
- js-yaml 5.4.0 reworked scalar style selection and rewrote
sortKeys. DUMP_OPTSsetsquotingType: '"'; under 5.5.0 strings come out single-quoted anyway.- The top-level
onkey now dumps as'on':;unquoteOnKeyonly matches"on":, so the key stays quoted and the# zizmor: ignore[dangerous-triggers]suffix is dropped fromautomation-caller.yml. - The bump also adds
argparse@^3.0.3as a transitive dependency; no other package must move with it.
The Change
js-yamlshould be upgraded to 5.5.0 or later inpackage.jsonandyarn.lock.- The generator should select double-quoted strings through the js-yaml 5 scalar style options (5.4.0 added
scalarStyleRules). unquoteOnKeyshould match theonkey as js-yaml 5 emits it.
How to Get There
Install the dependency branch from #118 (dependabot/npm_and_yarn/js-yaml-5.5.0), then run node scripts/generate-automation.js --check.
Acceptance Criteria
-
package.jsonandyarn.lockpinjs-yamlat 5.5.0 or later. -
node scripts/generate-automation.js --checkpasses, and the prek CI job is green. -
automation.yml,automation-caller.yml,automation-group-issues.yml,automation-group-pull-request-target.ymlandautomation-template.ymlkeep double-quoted strings and a bareon:key. -
automation-caller.ymlkeepson: # zizmor: ignore[dangerous-triggers]. - Any remaining diff in the generated files is committed alongside the generator change.
References
AI usage
rtibblesbot (Claude Code) reviewed #118, recommended closing it, and drafted this issue from that review.
Filed from #118's review.
- 主要语言
- JavaScript
- 星标
- 1
- 派生
- 7
- 平均合并
- 2 天 8 小时
- 30 天内合并 PR
- 10
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
learningequality/.github 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
learningequality/.github#112 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 42/100
learningequality/.github#130 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 45/100
learningequality/.github#129 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 24/100
learningequality/.github#128 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 58/100
learningequality/.github#127 ·
维护者通常 1 天内回复
查看 learningequality/.github 的全部 Issue
相似的 Issue
-
ep:WebGPU platform:web quantization
难度 2/5 1-3 小时 新手友好度 66/100
microsoft/onnxruntime#33752 ·
维护者通常 2 天内回复
-
icon request
难度 2/5 1-3 小时 新手友好度 66/100
tabler/tabler-icons#1693 ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 72/100
alvarotrigo/fullPage.js#4755 ·
-
难度 2/5 1-3 小时 新手友好度 64/100
jlab-sensing/ENTS-backend#854 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 76/100
andromarces/agent-loops#1242 ·
维护者通常 1 天内回复