Migrate generate-automation.js to js-yaml 5
維護者通常 1 天內回覆
評估
這個 Issue 還沒有評估資料。
描述
❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.
Overview
Dependabot PR #118 bumps the js-yaml devDependency from 4.1.0 to 5.5.0 and was closed unmerged: under 5.x, scripts/generate-automation.js emits different YAML, so the generate-automation prek hook (node scripts/generate-automation.js --check) fails on all five generated files. The generator needs to produce the current output under js-yaml 5 before the bump can land.
Complexity: Low
Target branch: main
Context
- js-yaml 5.4.0 reworked scalar style selection and rewrote
sortKeys. DUMP_OPTSsetsquotingType: '"'; under 5.5.0 strings come out single-quoted anyway.- The top-level
onkey now dumps as'on':;unquoteOnKeyonly matches"on":, so the key stays quoted and the# zizmor: ignore[dangerous-triggers]suffix is dropped fromautomation-caller.yml. - The bump also adds
argparse@^3.0.3as a transitive dependency; no other package must move with it.
The Change
js-yamlshould be upgraded to 5.5.0 or later inpackage.jsonandyarn.lock.- The generator should select double-quoted strings through the js-yaml 5 scalar style options (5.4.0 added
scalarStyleRules). unquoteOnKeyshould match theonkey as js-yaml 5 emits it.
How to Get There
Install the dependency branch from #118 (dependabot/npm_and_yarn/js-yaml-5.5.0), then run node scripts/generate-automation.js --check.
Acceptance Criteria
-
package.jsonandyarn.lockpinjs-yamlat 5.5.0 or later. -
node scripts/generate-automation.js --checkpasses, and the prek CI job is green. -
automation.yml,automation-caller.yml,automation-group-issues.yml,automation-group-pull-request-target.ymlandautomation-template.ymlkeep double-quoted strings and a bareon:key. -
automation-caller.ymlkeepson: # zizmor: ignore[dangerous-triggers]. - Any remaining diff in the generated files is committed alongside the generator change.
References
AI usage
rtibblesbot (Claude Code) reviewed #118, recommended closing it, and drafted this issue from that review.
Filed from #118's review.
- 主要語言
- JavaScript
- 星號
- 1
- 分支
- 7
- 平均合併
- 2 天 8 小時
- 30 天內合併 PR
- 10
環境準備
- 沒有 Dockerfile 或 Docker Compose 檔案
- 有 Pull Request 範本
- 閱讀貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
learningequality/.github 的其他 Issue
-
難度 2/5 1-3 小時 新手友好度 75/100
learningequality/.github#112 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 42/100
learningequality/.github#130 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 45/100
learningequality/.github#129 ·
維護者通常 1 天內回覆
-
難度 5/5 一週以上 新手友好度 24/100
learningequality/.github#128 ·
維護者通常 1 天內回覆
-
難度 4/5 3-5 天 新手友好度 58/100
learningequality/.github#127 ·
維護者通常 1 天內回覆
查看 learningequality/.github 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 76/100
Graphify-Labs/graphify#4860 · 1 則留言 ·
維護者通常 1 天內回覆
-
難度 2/5 1-3 小時 新手友好度 65/100
CommandCodeAI/command-code#1088 ·
維護者通常 2 天內回覆
-
難度 2/5 1-3 小時 新手友好度 78/100
CanadaHonk/porffor#426 ·
-
難度 2/5 1-3 小時 新手友好度 66/100
-
bug
難度 2/5 1-3 小時 新手友好度 66/100
RIT-Software-Engineering/RIT-SE-Senior-Project#546 ·
維護者通常 1 天內回覆