Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Migrate generate-automation.js to js-yaml 5

Ouverte
  • Quelque chose ne va pas ?
#122 1 commentaire 1 réaction 1 personne assignée Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

@rtibblesbot y travaille déjà.

Depuis le 25/10/2026.

  • #125 par @rtibblesbot — ouverte

Évaluation

Cette issue n'a pas encore été évaluée.

Description

community-contribution-in-progress dependencies javascript

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Dependabot PR #118 bumps the js-yaml devDependency from 4.1.0 to 5.5.0 and was closed unmerged: under 5.x, scripts/generate-automation.js emits different YAML, so the generate-automation prek hook (node scripts/generate-automation.js --check) fails on all five generated files. The generator needs to produce the current output under js-yaml 5 before the bump can land.

Complexity: Low
Target branch: main

Context
  • js-yaml 5.4.0 reworked scalar style selection and rewrote sortKeys.
  • DUMP_OPTS sets quotingType: '"'; under 5.5.0 strings come out single-quoted anyway.
  • The top-level on key now dumps as 'on':; unquoteOnKey only matches "on":, so the key stays quoted and the # zizmor: ignore[dangerous-triggers] suffix is dropped from automation-caller.yml.
  • The bump also adds argparse@^3.0.3 as a transitive dependency; no other package must move with it.
The Change
  • js-yaml should be upgraded to 5.5.0 or later in package.json and yarn.lock.
  • The generator should select double-quoted strings through the js-yaml 5 scalar style options (5.4.0 added scalarStyleRules).
  • unquoteOnKey should match the on key as js-yaml 5 emits it.
How to Get There

Install the dependency branch from #118 (dependabot/npm_and_yarn/js-yaml-5.5.0), then run node scripts/generate-automation.js --check.

Acceptance Criteria
  • package.json and yarn.lock pin js-yaml at 5.5.0 or later.
  • node scripts/generate-automation.js --check passes, and the prek CI job is green.
  • automation.yml, automation-caller.yml, automation-group-issues.yml, automation-group-pull-request-target.yml and automation-template.yml keep double-quoted strings and a bare on: key.
  • automation-caller.yml keeps on: # zizmor: ignore[dangerous-triggers].
  • Any remaining diff in the generated files is committed alongside the generator change.
References

AI usage

rtibblesbot (Claude Code) reviewed #118, recommended closing it, and drafted this issue from that review.

Filed from #118's review.

Langage dominant
JavaScript
Étoiles
1
Forks
7
Merge moyen
2 j 8 h
PR mergées (30 j)
10

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de learningequality/.github

Toutes les issues de learningequality/.github

Issues similaires

Plus d'issues JavaScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.