Hacktoberfest 2026: as issues que os mantenedores marcaram para outubro, abertas e boas para iniciantes. Ver issues do Hacktoberfest

Migrate generate-automation.js to js-yaml 5

Aberta
  • Algo errado?
#122 1 comentário 1 reação 1 responsável Ver no GitHub

Mantenedores costumam responder em até 1 dia

@rtibblesbot já está trabalhando nisso.

Desde 25/10/2026.

  • #125 de @rtibblesbot — aberto

Avaliação

Esta issue ainda não foi avaliada.

Descrição

community-contribution-in-progress dependencies javascript

❌ This issue is not open for contribution. Visit Contributing guidelines to learn about the contributing process and how to find suitable issues.

Overview

Dependabot PR #118 bumps the js-yaml devDependency from 4.1.0 to 5.5.0 and was closed unmerged: under 5.x, scripts/generate-automation.js emits different YAML, so the generate-automation prek hook (node scripts/generate-automation.js --check) fails on all five generated files. The generator needs to produce the current output under js-yaml 5 before the bump can land.

Complexity: Low
Target branch: main

Context
  • js-yaml 5.4.0 reworked scalar style selection and rewrote sortKeys.
  • DUMP_OPTS sets quotingType: '"'; under 5.5.0 strings come out single-quoted anyway.
  • The top-level on key now dumps as 'on':; unquoteOnKey only matches "on":, so the key stays quoted and the # zizmor: ignore[dangerous-triggers] suffix is dropped from automation-caller.yml.
  • The bump also adds argparse@^3.0.3 as a transitive dependency; no other package must move with it.
The Change
  • js-yaml should be upgraded to 5.5.0 or later in package.json and yarn.lock.
  • The generator should select double-quoted strings through the js-yaml 5 scalar style options (5.4.0 added scalarStyleRules).
  • unquoteOnKey should match the on key as js-yaml 5 emits it.
How to Get There

Install the dependency branch from #118 (dependabot/npm_and_yarn/js-yaml-5.5.0), then run node scripts/generate-automation.js --check.

Acceptance Criteria
  • package.json and yarn.lock pin js-yaml at 5.5.0 or later.
  • node scripts/generate-automation.js --check passes, and the prek CI job is green.
  • automation.yml, automation-caller.yml, automation-group-issues.yml, automation-group-pull-request-target.yml and automation-template.yml keep double-quoted strings and a bare on: key.
  • automation-caller.yml keeps on: # zizmor: ignore[dangerous-triggers].
  • Any remaining diff in the generated files is committed alongside the generator change.
References

AI usage

rtibblesbot (Claude Code) reviewed #118, recommended closing it, and drafted this issue from that review.

Filed from #118's review.

Linguagem predominante
JavaScript
Estrelas
1
Forks
7
Merge médio
2d 8h
PRs com merge (30d)
10

Preparar o ambiente

Primeiros passos

  1. Leia a issue inteira e depois o guia de contribuição do projeto.
  2. Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
  3. Faça um fork do repositório e trabalhe em uma branch.
  4. Abra um pull request que referencie o número da issue.

Mais de learningequality/.github

Todas as issues de learningequality/.github

Issues semelhantes

Mais issues de JavaScript

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.