Hyperstack.on_server? can do much better please
还没有人认领这个 Issue。
评估
调研方向
首先跟踪 Hyperstack.on_server? 和 issue 中描述的 initializer 覆盖,然后比较其中提到的 simple_poller 和 Action Cable 模式。完成的标准是:使用 forward_messages_to_server? 替代对服务器位置的假设,并通过配置或行为检查避免不必要的转发,同时保留所需的广播。
由索引模型根据 Issue 内容生成。
描述
Currently Hyperstack.on_server? returns false if you not on the rails server (i.e. on the console or on in a sidekiq worker).
The system uses this to decide if it needs to forward any broadcasts to the server from, under the assumption that if you are not on the server you do not have access to the broadcast mechanism.
This assumption is pretty weak. The following are known cases where it doesn't matter:
you are using simple_poller (in this case you are going to shove the message into a queue, and wait for the next poll)
you are using action_cable NOT in async mode. (i.e. the connection data is stored in a database, not in the servers memory)
Not tested is pusher, and actually not tested (but I'm sure it would work is action_cable and redis)
Soooo...
This method should be called: forward_messages_to_server?
and should check to see if we have to forward it, by a combination of checking configuration and/or checking actual behavior.
Why should I care?
Because if you are using a lot of outside processes to do stuff, then you are adding unneeded overhead forwarding this stuff to the server.
The current work around is very simple: Just add this line to the hyperstack initializer
def Hyperstack.on_server?; true; end
- 主要语言
- JavaScript
- 星标
- 538
- 派生
- 41
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
hyperstack-org/hyperstack 的其他 Issue
-
enhancement needs doc
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#359 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
hyperstack-org/hyperstack#267 ·
-
难度 5/5 一周以上 新手友好度 25/100
hyperstack-org/hyperstack#457 ·
-
难度 3/5 1-2 天 新手友好度 35/100
hyperstack-org/hyperstack#456 ·
-
难度 5/5 一周以上 新手友好度 15/100
hyperstack-org/hyperstack#455 · 2 条评论 ·
查看 hyperstack-org/hyperstack 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
palladius/rails8-app-on-gcp#145 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
dotenvx/dotenv-vscode#139 ·
-
test-change-proposal
难度 2/5 1-3 小时 新手友好度 65/100
web-platform-tests/interop#1455 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
corsairdev/corsair#1764 ·
-
难度 2/5 1-3 小时 新手友好度 75/100