Hyperstack.on_server? can do much better please
還沒有人認領這個 Issue。
評估
研究方向
先追蹤 Hyperstack.on_server? 以及 issue 中描述的 initializer 覆寫，接著比較其中提到的 simple_poller 和 Action Cable 模式。完成的標準是：使用 forward_messages_to_server? 取代對伺服器位置的假設，並透過設定或行為檢查避免不必要的轉送，同時保留必要的廣播。
由索引模型根據 Issue 內容生成。
描述
Currently Hyperstack.on_server? returns false if you not on the rails server (i.e. on the console or on in a sidekiq worker).
The system uses this to decide if it needs to forward any broadcasts to the server from, under the assumption that if you are not on the server you do not have access to the broadcast mechanism.
This assumption is pretty weak. The following are known cases where it doesn't matter:
you are using simple_poller (in this case you are going to shove the message into a queue, and wait for the next poll)
you are using action_cable NOT in async mode. (i.e. the connection data is stored in a database, not in the servers memory)
Not tested is pusher, and actually not tested (but I'm sure it would work is action_cable and redis)
Soooo...
This method should be called: forward_messages_to_server?
and should check to see if we have to forward it, by a combination of checking configuration and/or checking actual behavior.
Why should I care?
Because if you are using a lot of outside processes to do stuff, then you are adding unneeded overhead forwarding this stuff to the server.
The current work around is very simple: Just add this line to the hyperstack initializer
def Hyperstack.on_server?; true; end
- 主要語言
- JavaScript
- 星號
- 538
- 分支
- 41
- PR 合併指標
- 30 天內沒有已合併 PR
貢獻指南
從這裡開始
- 先讀完整個 Issue，再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫，在一個分支上完成修改。
- 送出 Pull Request，並在描述裡引用這個 Issue 編號。
hyperstack-org/hyperstack 的其他 Issue
-
enhancement needs doc
難度 2/5 1-3 小時 新手友好度 68/100
hyperstack-org/hyperstack#359 ·
-
難度 2/5 1-3 小時 新手友好度 68/100
hyperstack-org/hyperstack#267 ·
-
難度 5/5 一週以上 新手友好度 25/100
hyperstack-org/hyperstack#457 ·
-
難度 3/5 1-2 天 新手友好度 35/100
hyperstack-org/hyperstack#456 ·
-
難度 5/5 一週以上 新手友好度 15/100
hyperstack-org/hyperstack#455 · 2 則留言 ·
查看 hyperstack-org/hyperstack 的全部 Issue
相似的 Issue
-
難度 2/5 1-3 小時 新手友好度 65/100
-
難度 2/5 1-3 小時 新手友好度 75/100
docToolchain/docToolchain#1705 ·
-
Timezone select lists one option per character; duplicate "Failed" reason; shared tracker popover id 未關閉bug
難度 2/5 1-3 小時 新手友好度 75/100
nightscout/nocturne#1414 ·
-
bug v2
難度 2/5 1-3 小時 新手友好度 75/100
modelcontextprotocol/inspector#2458 · 1 則留言 ·
-
Mend: dependency security vulnerability status: needs triage 🕵️♀️
難度 2/5 1-3 小時 新手友好度 70/100
carbon-design-system/ibm-products#9907 ·