False Positive: "Statement has no effect" on Airflow task chaining with >> operator
还没有人认领这个 Issue。
评估
调研方向
首先,使用 issue 中的最小 Apache Airflow Python 示例重现该警报。阅读与“Statement has no effect”警报相关的 CodeQL 查询和 Python 建模,然后确定如何分析重载的 >> 表达式。完成的标准是:Airflow 任务链式调用语句不再被报告,同时真正无效果的语句仍然可以被检测到。
由索引模型根据 Issue 内容生成。
描述
Description of the false positive
The CodeQL analysis is reporting a "Statement has no effect" false positive when using Apache Airflow's operator chaining syntax with >>. This is a valid and idiomatic way to declare task dependencies in Airflow DAGs, and these statements have clear side effects within the context of Airflow’s task graph construction.
Code samples or links to source code
The following is a minimal reproducible example using Apache Airflow:
from airflow import DAG
from airflow.operators.empty import EmptyOperator
from datetime import datetime
with DAG("example_dag", start_date=datetime(2025, 6, 5), schedule_interval=None) as dag:
task_1 = EmptyOperator(task_id="task_1")
task_2 = EmptyOperator(task_id="task_2")
task_3 = EmptyOperator(task_id="task_3")
task_4 = EmptyOperator(task_id="task_4")
task_1 >> task_2 # CodeQL incorrectly flags this
task_2 >> [task_3, task_4] # CodeQL incorrectly flags this too
These lines are not no-op statements; they define execution order between tasks (task_1 precedes task_2, etc.). Removing them would break DAG functionality.
URL to the alert on GitHub code scanning (optional)
Code is proprietary.
Suggested solution
If possible, please provide a way to configure CodeQL to ignore >> operator overload on Airflow operator objects, which have intentional and important side effects.. Please note that this operator works only in DAG context manager (with DAG(...) as dag:).
If that's not feasible, then I would greatly appreciate help setting up custom CodeQL rule to ignore this false positive.
- 主要语言
- CodeQL
- 星标
- 10.1k
- 派生
- 2.1k
- 平均合并
- 2 天 10 小时
- 30 天内合并 PR
- 134
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
github/codeql 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 84/100
-
难度 2/5 1-3 小时 新手友好度 82/100
-
难度 2/5 1-3 小时 新手友好度 78/100
-
false-positive
难度 2/5 1-3 小时 新手友好度 70/100
-
false-positive
难度 3/5 1-2 天 新手友好度 68/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
ScoopInstaller/Nonportable#639 ·
-
难度 2/5 1-3 小时 新手友好度 68/100
ScoopInstaller/Extras#18800 ·
-
难度 1/5 1 小时以内 新手友好度 85/100
uqbar-project/website-wollok-ts#84 · 2 条评论 ·
-
on hold T: core-bug
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 88/100